Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 33 additions & 7 deletions src/tiled/propertiesview.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -657,28 +657,54 @@ QWidget *BaseEnumProperty::createEnumEditor(QWidget *parent)
{
auto editor = new ComboBox(parent);

for (qsizetype i = 0; i < m_enumData.names.size(); ++i) {
auto value = m_enumData.values.value(i, i);
editor->addItem(m_enumData.icons[value],
m_enumData.names[i],
value);
}
auto setupEditor = [this, editor] {
const QSignalBlocker blocker(editor);
editor->clear();

for (qsizetype i = 0; i < m_enumData.names.size(); ++i) {
auto value = m_enumData.values.value(i, i);
editor->addItem(m_enumData.icons[value],
m_enumData.names[i],
value);
}
};

auto syncEditor = [this, editor] {
const QSignalBlocker blocker(editor);
editor->setCurrentIndex(editor->findData(value()));
};

setupEditor();
syncEditor();

connect(this, &Property::valueChanged, editor, syncEditor);
connect(this, &BaseEnumProperty::enumDataChanged, editor, [=] {
setupEditor();
syncEditor();
});
connect(editor, &QComboBox::currentIndexChanged, this,
[editor, this] {
[editor, this] {
setValue(editor->currentData().toInt());
});

return editor;
}

void BaseEnumProperty::setEnumData(const EnumData &enumData)
{
m_enumData = enumData;
emit enumDataChanged(m_enumData);
}

void BaseEnumProperty::setEnumNames(const QStringList &names)
{
if (m_enumData.names == names)
return;

m_enumData.names = names;
emit enumDataChanged(m_enumData);
}

QWidget *BaseEnumProperty::createFlagsEditor(QWidget *parent)
{
auto editor = new QWidget(parent);
Expand Down
7 changes: 6 additions & 1 deletion src/tiled/propertiesview.h
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@

#include <QHash>
#include <QIcon>
#include <QMap>
#include <QPointer>
#include <QScrollArea>
#include <QString>
Expand Down Expand Up @@ -503,7 +504,8 @@ class BaseEnumProperty : public IntProperty
public:
using IntProperty::IntProperty;

void setEnumData(const EnumData &enumData) { m_enumData = enumData; }
void setEnumData(const EnumData &enumData);
void setEnumNames(const QStringList &names);
void setFlags(bool flags) { m_flags = flags; }

QWidget *createEditor(QWidget *parent) override
Expand All @@ -512,6 +514,9 @@ class BaseEnumProperty : public IntProperty
: createEnumEditor(parent);
}

signals:
void enumDataChanged(const EnumData &enumData);

protected:
QWidget *createFlagsEditor(QWidget *parent);
QWidget *createEnumEditor(QWidget *parent);
Expand Down
29 changes: 25 additions & 4 deletions src/tiled/propertieswidget.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -101,8 +101,8 @@ template<> EnumData enumData<Map::Orientation>()
template<> EnumData enumData<Map::StaggerAxis>()
{
return {{
QCoreApplication::translate("StaggerAxis", "X"),
QCoreApplication::translate("StaggerAxis", "Y")
QCoreApplication::translate("StaggerAxis", "X (Flat-top)"),
QCoreApplication::translate("StaggerAxis", "Y (Pointy-top)")
}};
}

Expand Down Expand Up @@ -871,9 +871,11 @@ class MapProperties : public ObjectProperties
mMapProperties->addProperty(mRenderOrderProperty);
mMapProperties->addProperty(mBackgroundColorProperty);

updateStaggerAxisLabels();
updateEnabledState();

addProperty(mMapProperties);

updateEnabledState();
connect(document, &Document::changed,
this, &MapProperties::onChanged);
}
Expand Down Expand Up @@ -905,6 +907,7 @@ class MapProperties : public ObjectProperties
emit mParallaxOriginProperty->valueChanged();
break;
case Map::OrientationProperty:
updateStaggerAxisLabels();
emit mOrientationProperty->valueChanged();
break;
case Map::RenderOrderProperty:
Expand Down Expand Up @@ -952,6 +955,24 @@ class MapProperties : public ObjectProperties
}
}

void updateStaggerAxisLabels()
{
switch (map()->orientation()) {
case Map::Hexagonal:
mStaggerAxisProperty->setEnumNames({
tr("X (Flat-top)"),
tr("Y (Pointy-top)")
});
break;
default:
mStaggerAxisProperty->setEnumNames({
tr("X"),
tr("Y")
});
break;
}
}

MapDocument *mapDocument() const
{
return static_cast<MapDocument*>(mDocument);
Expand All @@ -968,7 +989,7 @@ class MapProperties : public ObjectProperties
SizeProperty *mTileSizeProperty;
BoolProperty *mInfiniteProperty;
IntProperty *mHexSideLengthProperty;
Property *mStaggerAxisProperty;
BaseEnumProperty *mStaggerAxisProperty;
Property *mStaggerIndexProperty;
Property *mParallaxOriginProperty;
Property *mLayerDataFormatProperty;
Expand Down
Loading