Multithread bam read #812
Merged
Multithread bam read #812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhpvorderman
force-pushed
the
multithread_bam_read
branch
from
ca72ac8
to
1aae919
Compare
This is still on my to-do list, but not very high. The adapter ends in ONT Nanopore don't interfere with alignment at all and seem to have very little effect (within 1% error-margin) on variant calling. So the priority to allow proper methylation tag support when cutting has somewhat lessened. Currently I have a lot of work to do so I will pick that up at a later date. For now I have made sure that multithreaded BAM reading works with the latest version of dnaio so that it can be included into the new version of cutadapt. Hence the @marcelm ping, so you know it is ready :-). |
|
Looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pending. This works on marcelm/dnaio#141. We might want to add additional functionality to dnaio 1.3.0 for other uBAM support features.