Feature #58 - Audit trail report #209
Conversation
SilviaAmAm
force-pushed
the
feature/58-audit-trail
branch
from
36c1e26
to
8e1d355
Compare
|
An example of the PDF report with the Audit trail: |
SilviaAmAm
requested review from
annashamray
and removed request for
annashamray
There was a problem hiding this comment.
Nice implementation with reusing audit trails!
The only thing which is bothering me - zaak identifications are not specified in most log entries (creating, updating and reviewing the destruction list).
For example, a record manager created a DL with two zaken A and B
The reviewer asks to remove the zaak A, and the record manager excludes it.
If they have not specified the identificatie of the zaak A in their comments, archivaris will never find out what particular zaak was excluded from the DL
I don't know if it's a necessary information or not and if it should be added to the audit trails
src/archiefvernietigingscomponent/destruction/management/commands/convert_log_templates.py
Outdated
Show resolved
Hide resolved
src/archiefvernietigingscomponent/destruction/management/commands/convert_log_templates.py
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,14 @@ | |||
| {% load i18n %} | |||
| <code class="log-item__title" title="{{ log.timestamp.isoformat }}"> | |||
| <strong>[{{ log.timestamp|date:'Y-m-d H:i' }}]:</strong> | |||
There was a problem hiding this comment.
css property font-weight can be used instead of <strong> html tag. It's not necessary to change it back but I think putting all formatting in one place (css file) is more convinient
There was a problem hiding this comment.
I made an issue for this (#222): I need to figure out how to nicely handle CSS with weasyprint, for when the HTML is converted to a PDF.
...efvernietigingscomponent/destruction/templates/destruction/logs/item_destruction_failed.html
Show resolved
Hide resolved
...archiefvernietigingscomponent/destruction/templates/destruction/logs/item_update_failed.html
Show resolved
Hide resolved
src/archiefvernietigingscomponent/report/templates/report/audittrail/audittrail.html
Show resolved
Hide resolved
SilviaAmAm
force-pushed
the
feature/58-audit-trail
branch
from
a557f0f
to
0536e1e
Compare
|
Latest version of the report :) |
SilviaAmAm
force-pushed
the
feature/58-audit-trail
branch
from
0536e1e
to
b32eccb
Compare
Fixes #58