Skip to content

fix: Add missing required sections to 28 non-compliant skills #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
martincjarvis merged 1 commit into from
Jan 17, 2026
Merged

fix: Add missing required sections to 28 non-compliant skills #391

martincjarvis merged 1 commit into from
Jan 17, 2026

Conversation

@mcj-coder
Copy link
Owner

@mcj-coder mcj-coder commented Jan 17, 2026 •
edited
Loading

Summary

  • Added missing "When to Use" section to 4 skills
  • Added missing "Core Workflow" section to 8 skills
  • Added both missing sections to 15 skills
  • Added all 3 required sections (Overview, When to Use, Core Workflow) to 1 skill

All 55 skills now pass npm run validate:skills.

Issues

Test Plan

  • npm run validate:skills - All 55 skills pass (evidence)
  • npm run lint - All checks pass (evidence)

Skills Modified (28 total)

Missing only "When to Use" (4)

  • agents-onboarding
  • component-boundary-ownership
  • process-skill-router
  • requirements-gathering

Missing only "Core Workflow" (8)

  • broken-window
  • dotnet-best-practices
  • finishing-a-development-branch
  • pair-programming
  • persona-switching
  • safe-brownfield-refactor
  • scoped-colocation
  • testing-strategy-agnostic

Missing both sections (15)

  • agent-workitem-automation
  • csharp-best-practices
  • dotnet-bespoke-code-minimisation
  • dotnet-domain-primitives
  • dotnet-efcore-practices
  • dotnet-healthchecks
  • dotnet-mapping-standard
  • dotnet-open-source-first-governance
  • dotnet-source-generation-first
  • dotnet-specification-pattern
  • dotnet-testing-assertions
  • innersource-governance-bootstrap
  • observability-logging-baseline
  • security-processes
  • testing-strategy-dotnet

Missing all 3 sections (1)

  • dotnet-logging-serilog

🤖 Generated with Claude Code

@mcj-coder @claude
fix(skills): add missing required sections to 28 non-compliant skills
9f8b13b 
Added missing sections per SKILL-FORMAT.md requirements:
- 4 skills: Added "When to Use" section
- 8 skills: Added "Core Workflow" section
- 15 skills: Added both "When to Use" and "Core Workflow" sections
- 1 skill: Added "Overview", "When to Use", and "Core Workflow" sections

All 55 skills now pass `npm run validate:skills`.

Refs: #390

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@github-actions
Copy link

github-actions bot commented Jan 17, 2026 •
edited
Loading

Warnings
⚠️

[Issue] 31 checked acceptance criteria may be missing evidence links. Recommended format: - [x] Item (evidence)
Messages
📖 All PR validation checks passed.

Generated by 🚫 dangerJS against 9f8b13b

@mcj-coder mcj-coder mentioned this pull request Jan 17, 2026
Closed
32 tasks
martincjarvis
martincjarvis approved these changes Jan 17, 2026
View reviewed changes
Copy link
Collaborator

@martincjarvis martincjarvis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - All 28 skills now have required sections. Validation passes.

@martincjarvis martincjarvis merged commit 8c769bc into main Jan 17, 2026
11 of 12 checks passed
@martincjarvis martincjarvis deleted the fix/skill-compliance-sections branch January 17, 2026 12:31
This was referenced Jan 17, 2026
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@martincjarvis martincjarvis martincjarvis approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

fix: Add missing required sections to 28 non-compliant skills

3 participants

@mcj-coder @martincjarvis