add: instance methods SVGAnimationElement #37180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Content:WebAPI
|
Preview URLs
(comment last updated: 2025-01-12 04:14:20) |
This was referenced Dec 11, 2024
wbamberg
reviewed
Jan 9, 2025
files/en-us/web/api/svganimationelement/getcurrenttime/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/svganimationelement/getsimpleduration/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/svganimationelement/getsimpleduration/index.md
Outdated
Show resolved
Hide resolved
|
Thanks for the review! I will start fixing these right away, as a question, should I also make these changes to the SVGAnimationElement Web API page as they are consistent with the description there. |
Oh, I didn't know this was the same as the interface page. Yes, if you can find a better way to express this then it would be good to update that page as well. However if the explanation is long, it's better not to include the full explanation in the interface page. |
wbamberg
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of Missing baseline pages project