Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(workflows): migrate pr-test to rari #25577

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Jan 24, 2025

Description

Migrates the pr-test workflow to rari.

Motivation

Additional details

The existing pr-test workflow was renamed to pr-test-legacy, and disabled.

Both workflows now use the pull_request event, while pr-review-companion uses the workflow_run event.

Related issues and pull requests

Related content PRs:

@caugner caugner requested a review from a team as a code owner January 24, 2025 12:46
@github-actions github-actions bot added the system Infrastructure and configuration for the project label Jan 24, 2025
@@ -42,12 +58,14 @@
key: dotlocal-${{ runner.os }}-${{ steps.setup-python.outputs.python-version }}-0

- name: Install Python poetry
uses: snok/install-poetry@v1
if: env.HAS_ARTIFACT
uses: snok/[email protected]

Check warning

Code scanning / CodeQL

Unpinned tag for a non-immutable Action in workflow Medium

Unpinned 3rd party Action 'PR review companion' step
Uses Step
uses 'snok/install-poetry' with ref 'v1.4', not a pinned commit hash
@caugner caugner requested a review from a team as a code owner January 24, 2025 12:48
@caugner caugner requested review from tristantheb and removed request for a team January 24, 2025 12:48
@github-actions github-actions bot added the l10n-fr Issues related to French content. label Jan 24, 2025
Copy link
Contributor

github-actions bot commented Jan 24, 2025

Preview URLs

Flaws (1)

URL: /fr/docs/Web
Title: Technologies web pour développeurs
Flaw count: 1

  • broken_links:
    • Link points to the page it's already on

(comment last updated: 2025-01-24 12:52:17)

@github-actions github-actions bot removed the l10n-fr Issues related to French content. label Jan 24, 2025
@caugner caugner removed the request for review from tristantheb January 24, 2025 12:53
@caugner caugner force-pushed the MP-1851-migrate-pr-test-to-rari branch from f60d9eb to 6e450c2 Compare January 24, 2025 14:28
The existing `pr-test` workflow was renamed to `pr-test-legacy`.

Both workflows now use the `pull_request` event, while
`pr-review-companion` uses the `workflow_run` event.

# Conflicts:
#	.github/workflows/pr-review-companion.yml
#	.github/workflows/pr-test.yml
@caugner caugner force-pushed the MP-1851-migrate-pr-test-to-rari branch from 6e450c2 to 145be21 Compare January 24, 2025 14:28
Copy link
Contributor

@argl argl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@caugner caugner merged commit 27bc5f4 into main Jan 24, 2025
11 of 12 checks passed
@caugner caugner deleted the MP-1851-migrate-pr-test-to-rari branch January 24, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
system Infrastructure and configuration for the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants