Fix rounding issue on refund #14496
Open
Fix rounding issue on refund #14496
+33
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 97cf59a The changes in this PR will be included in the next version bump. This PR includes changesets to release 76 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@pepijn-vanvlaanderen is attempting to deploy a commit to the medusajs Team on Vercel. A member of the Team first needs to authorize it. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
packages/core/core-flows/src/payment/workflows/refund-payment.ts
Outdated
Show resolved
Hide resolved
Comment on lines
+89
to
+92
| MathBN.gte( | ||
| MathBN.sub(totalRefundedAmount, capturedAmount), | ||
| currencyEpsilon | ||
| ) |
Contributor
There was a problem hiding this comment.
Hi @pepijn-vanvlaanderen,
even though this is correct, would you mind invert the check to make it easier to read?
MathBN.lt( MathBN.sub(captured, refund), epsilon )
| ) | ||
|
|
||
| if ( | ||
| MathBN.gte( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
What — What changes are introduced in this PR?
When a payment collection exists with a payment amount of >2 decimal, you could encounter the error 'You are not allowed to refund more than the captured amount'.
Why — Why are these changes relevant or necessary?
For example when an order got paid 87,96, but the captured amount is 87.957975, you will hit this issue and you are not allowed to do the full refund.
How — How have these changes been implemented?
Updated the validation rule and payment module to do a check based on the currencyEpsilon introduced in #14225.
Testing — How have these changes been tested, or how can the reviewer test the feature?
Implemented and tested on our own projects. Existing tests should pass.
Examples
Provide examples or code snippets that demonstrate how this feature works, or how it can be used in practice.
This helps with documentation and ensures maintainers can quickly understand and verify the change.
// Example usageChecklist
Please ensure the following before requesting a review:
yarn changesetand follow the promptsNote
Fix rounding-related refund validation
refund-paymentworkflow andPaymentModuleService.refundPayment_to compare(total_refunded - captured)againstcurrencyEpsilonderived fromdefaultCurrencies/getEpsilonFromDecimalPrecisioncurrency_codeis selected/used for epsilon calculation; only block refunds when the difference meets/exceeds epsilon@medusajs/core-flowsand@medusajs/paymentWritten by Cursor Bugbot for commit 97cf59a. This will update automatically on new commits. Configure here.