Skip to content

Fix rounding issue on refund #14496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pepijn-vanvlaanderen wants to merge 10 commits into
base: develop
Choose a base branch
from
+33 −2
Open

Fix rounding issue on refund #14496

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
1228268
Skip promotion usage limit checks on draft order edit flows
pepijn-vanvlaanderen Dec 30, 2025
dfb7a83
Fix rounding issue on refund
pepijn-vanvlaanderen Jan 8, 2026
4634ac4
Revert compute-draft-order-adjustments.ts
pepijn-vanvlaanderen Jan 8, 2026
0a7acac
Delete .changeset/stale-buses-jog.md
pepijn-vanvlaanderen Jan 8, 2026
c3e3695
Delete .changeset/tiny-parrots-live.md
pepijn-vanvlaanderen Jan 8, 2026
6650398
Merge branch 'develop' into fix/rounding-issue-on-refund
pepijn-vanvlaanderen Jan 8, 2026
66cdb01
Merge branch 'develop' into fix/rounding-issue-on-refund
pepijn-vanvlaanderen Jan 14, 2026
dd94360
Update mathbn sub
pepijn-vanvlaanderen Jan 14, 2026
c9d9ffa
Add select of currency_code
pepijn-vanvlaanderen Jan 14, 2026
97cf59a
Merge branch 'develop' into fix/rounding-issue-on-refund
pepijn-vanvlaanderen Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/grumpy-moles-listen.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@medusajs/core-flows": patch
"@medusajs/payment": patch
---

Fix rounding issue on refund creation
14 changes: 13 additions & 1 deletion packages/core/core-flows/src/payment/workflows/refund-payment.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
import { BigNumberInput, PaymentDTO } from "@medusajs/framework/types"
import {
BigNumber,
defaultCurrencies,
getEpsilonFromDecimalPrecision,
MathBN,
MedusaError,
PaymentEvents,
Expand Down Expand Up @@ -78,7 +80,17 @@ export const validateRefundPaymentExceedsCapturedAmountStep = createStep(

const totalRefundedAmount = MathBN.add(refundedAmount, refundAmount)

if (MathBN.lt(capturedAmount, totalRefundedAmount)) {
const upperCurCode = payment.currency_code?.toUpperCase() as string
const currencyEpsilon = getEpsilonFromDecimalPrecision(
defaultCurrencies[upperCurCode]?.decimal_digits
)

if (
MathBN.gte(
MathBN.sub(totalRefundedAmount, capturedAmount),
currencyEpsilon
)
Comment on lines +89 to +92
Copy link
Contributor

@carlos-r-l-rodrigues carlos-r-l-rodrigues Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @pepijn-vanvlaanderen,
even though this is correct, would you mind invert the check to make it easier to read?

MathBN.lt( MathBN.sub(captured, refund), epsilon )

) {
throw new MedusaError(
MedusaError.Types.INVALID_DATA,
`You are not allowed to refund more than the captured amount`
Expand Down
15 changes: 14 additions & 1 deletion packages/modules/payment/src/services/payment-module.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,9 @@ import {
} from "@medusajs/framework/types"
import {
BigNumber,
defaultCurrencies,
EmitEvents,
getEpsilonFromDecimalPrecision,
InjectManager,
InjectTransactionManager,
isPresent,
Expand Down Expand Up @@ -827,6 +829,7 @@ export default class PaymentModuleService
{
select: [
"id",
"currency_code",
"data",
"provider_id",
"payment_collection_id",
Expand Down Expand Up @@ -878,7 +881,17 @@ export default class PaymentModuleService

const totalRefundedAmount = MathBN.add(refundedAmount, data.amount)

if (MathBN.lt(capturedAmount, totalRefundedAmount)) {
const upperCurCode = payment.currency_code?.toUpperCase() as string
const currencyEpsilon = getEpsilonFromDecimalPrecision(
defaultCurrencies[upperCurCode]?.decimal_digits
)

if (
MathBN.gte(
Copy link
Contributor

@carlos-r-l-rodrigues carlos-r-l-rodrigues Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

MathBN.sub(totalRefundedAmount, capturedAmount),
currencyEpsilon
)
) {
throw new MedusaError(
MedusaError.Types.INVALID_DATA,
`You cannot refund more than what is captured on the payment.`
Expand Down
Loading