Skip to content

Evaluate existing segmentation #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 64 commits into from
Mar 25, 2025
Merged

Evaluate existing segmentation #213

merged 64 commits into from
Mar 25, 2025

Conversation

ziw-liu
Copy link
Collaborator

@ziw-liu ziw-liu commented Dec 4, 2024

Add data modules and lightning modules to evaluate segmentation generated outside of VisCy, e.g. with czbiohub-sf/biahub#17.

@ziw-liu ziw-liu added enhancement New feature or request translation Image translation (VS) labels Dec 4, 2024
@ziw-liu ziw-liu added this to the v0.4.0 milestone Dec 4, 2024
@ziw-liu ziw-liu changed the base branch from main to simple-cache December 4, 2024 05:51
@ziw-liu ziw-liu marked this pull request as ready for review December 7, 2024 05:25
@ziw-liu ziw-liu requested a review from edyoshikun December 7, 2024 05:25
Base automatically changed from simple-cache to main January 2, 2025 22:42
@ziw-liu
Copy link
Collaborator Author

ziw-liu commented Feb 7, 2025

@edyoshikun can I get a review on this?

@ziw-liu ziw-liu changed the title Evaluate existing segementation Evaluate existing segmentation Mar 20, 2025
@ziw-liu ziw-liu modified the milestones: v0.4.0, v0.3.0 Mar 20, 2025
@ziw-liu ziw-liu requested a review from talonchandler March 21, 2025 20:45
Copy link
Contributor

@edyoshikun edyoshikun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the super delay on this PR!!

I see this PR also adds the changes to support the iohub 0.2.0!
I was going to request that we do at a FOV inclusion/exclusion, but it looks like you do it in the next PR #218
Thank you!

@ziw-liu ziw-liu merged commit ab3a350 into main Mar 25, 2025
4 checks passed
@ziw-liu ziw-liu deleted the segmentation-module branch March 25, 2025 04:16
edyoshikun added a commit that referenced this pull request Apr 15, 2025
* caching dataloader

* caching data module

* black

* ruff

* Bump torch to 2.4.1 (#174)

* update torch >2.4.1

* black

* ruff

* adding timeout to ram_dataloader

* bandaid to cached dataloader

* fixing the dataloader using torch collate_fn

* replacing dictionary with single array

* loading prior to epoch 0

* Revert "replacing dictionary with single array"

This reverts commit 8c13f49.

* using multiprocessing manager

* add sharded distributed sampler

* add example script for ddp caching

* format and lint

* addding the custom distrb sampler to hcs_ram.py

* adding sampler to val train dataloader

* fix divisibility of the last shard

* hcs_ram format and lint

* data module that only crops and does not collate

* wip: execute transforms on the GPU

* path for if not ddp

* fix randomness in inversion transform

* add option to pop the normalization metadata

* move gpu transform definition back to data module

* add tiled crop transform for validation

* add stack channel transform for gpu augmentation

* fix typing

* collate before sending to gpu

* inherit gpu transforms for livecell dataset

* update fcmae engine to apply per-dataset augmentations

* format and lint hcs_ram

* fix abc type hint

* update docstring style

* disable grad for validation transforms

* improve sample image logging in fcmae

* fix dataset length when batch size is larger than the dataset

* fix docstring

* add option to disable normalization metadata

* inherit gpu transform for ctmc

* remove duplicate method overrride

* update docstring for ctmc

* allow skipping caching for large datasets

* make the fcmae module compatible with image translation

* remove prototype implementation

* fix import path

* Arbitrary prediction time transforms (#209)

* fix spelling in docstring and comment

* add batched zoom transform for tta

* add standalone lightning module for arbitrary TTA

* fix composition of different zoom factors

* add docstrings

* wip: segmentation module

* avoid casting

* update import path from iohub

* make integer array in fixture

* labels fixture

* test segmentation metrics modules

* less strings

* test non-empty

* select which wells to include in fit
#205

---------

Co-authored-by: Eduardo Hirata-Miyasaki <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request translation Image translation (VS)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants