-
Notifications
You must be signed in to change notification settings - Fork 6
demos for AQLM 2025 #446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
demos for AQLM 2025 #446
Conversation
I've given these notebooks a pass, and they now run end to end locally. The QPI simulation notebook runs on Colab, but I'm still trying to figure out |
Found a solution in FYI @edyoshikun @ziw-liu, |
I think the kernel needs to be restarted for the old version. But we should really update waveorder's dependencies. (#197) |
@talonchandler, the demos via google colab worked well. I updated the phase from defocus demo to illustrate 3D OTF's magnitude and phase, which sparked good discussion. Few observations and questions (I am getting familiar again with codebase and will continue to do so as we wrap up the paper):
|
@talonchandler why do we pin iohub to 0.1.0? This cell shows this error - but the notebook runs fine.
|
retardance, azimuth = setup.Birefringence_recon_2D( | ||
S1_stack, S2_stack, method="Tikhonov", reg_br=1e-2 | ||
) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a block on phase reconstruction as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps using waveorder.models.inplane_oriented_thick_pol3d_vector
That's correct. As much as possible we should use the code paths in
The reconstructions in
No longer needed! Thanks @ziw-liu --- see #448. @mattersoflight let's catch up on our plans here after your deadlines.
|
My thoughts below on what makes a good collection of test scripts and demos:
|
Adding a couple notes following our discussion @mattersoflight:
|
Hi @talonchandler since we decided to not work on docker with napari for now. I think we can proceed with current jupyter notebooks for "onboarding" new users. Do you need further review to merge these? |
I am adding two demos in the
examples/demos/
folder. These are based on simulations onexamples/maintanence
folder. During AQLM, we will finetune these demos. It would make sense to turn theexamples/maintenance
into non-interactive tests after we merge this PR.https://colab.research.google.com/github/mehta-lab/waveorder/blob/demos-aqlm/docs/examples/demos/QPI_defocus/QPI_defocus_simulation.ipynb