Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature request]: Nodes quick options #307

Draft
wants to merge 35 commits into
base: master
Choose a base branch
from
Draft

[Feature request]: Nodes quick options #307

wants to merge 35 commits into from

Conversation

KomelT
Copy link
Contributor

@KomelT KomelT commented Sep 18, 2024 •
edited
Loading

This PR adds the option to click on the node and get more options. Like in mobile apps.

ToDo:

  • Direct message
    • Open DM with that node
  • Request user info
    • Open dialog with new user info?
  • Request position
    • Open dialog with new position?
  • Traceroute
    • Show trace when getting a reply
  • Ignore
  • Remove
  • More details
    • Show device info
    • Show environment info
    • Show position

68747470733a2f2f73342e657a6769662e636f6d2f746d702f657a6769662d342d653430386632303963662e676966

@Hunter275
Copy link
Member

@KomelT

The image you linked 404s

image

@KomelT
Copy link
Contributor Author

KomelT commented Sep 18, 2024

@Hunter275 it is just gif of a feature. Now it should work.

@Hunter275 Hunter275 added enhancement New feature or request major change This is a major change labels Nov 10, 2024
@KomelT KomelT marked this pull request as ready for review January 23, 2025 22:24
@KomelT
Copy link
Contributor Author

KomelT commented Jan 23, 2025 •
edited
Loading

This should be good to go if there aren't any more wishes.

EDIT:
I forgot now there are 2 way traceroutes. I will try to add also that.

@KomelT
Copy link
Contributor Author

KomelT commented Jan 23, 2025

@Hunter275 now it should be ready
image

@KomelT
Copy link
Contributor Author

KomelT commented Jan 24, 2025

This is latest.
Screenshot_20250124_121025

@KomelT
Copy link
Contributor Author

KomelT commented Jan 30, 2025 •
edited
Loading

Screenshots of "Node Details"
Screenshot_20250130_180659
Screenshot_20250130_180712

Edit:
image
image

danditomaso
danditomaso requested changes Jan 30, 2025
View reviewed changes
src/components/generic/TimeAgo.tsx Outdated Show resolved Hide resolved
@danditomaso
Copy link
Collaborator

I think there is also some issues with the time ago that is being calculated (any nodes that show "days ago")

image

danditomaso
danditomaso requested changes Feb 3, 2025
View reviewed changes
Copy link
Collaborator

@danditomaso danditomaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments about useEffect usage

src/components/generic/TimeAgo.tsx Outdated Show resolved Hide resolved
src/components/generic/Uptime.tsx Outdated Show resolved Hide resolved
src/components/PageComponents/Messages/TraceRoute.tsx Outdated Show resolved Hide resolved
src/components/PageComponents/Messages/TraceRoute.tsx Outdated Show resolved Hide resolved
src/components/UI/Dialog.tsx Show resolved Hide resolved
@KomelT KomelT requested a review from danditomaso February 4, 2025 05:30
@KomelT KomelT mentioned this pull request Feb 4, 2025
Merged
@dzienisz
Copy link
Contributor

dzienisz commented Feb 4, 2025

Let's match every mobile and web feature for consistency. If that is possible. But it would be nice to add a checklist for PRa to not forget to check is changes work on web and mobile.

@KomelT
Copy link
Contributor Author

KomelT commented Feb 4, 2025

@dzienisz like that #403 ?

@dzienisz
Copy link
Contributor

dzienisz commented Feb 4, 2025

Yes! Like when it's UI/UX change it would be awesome to add before and after screenshots. Information it this was tested in the app, web and mobile view etc.

@KomelT KomelT marked this pull request as draft February 4, 2025 17:06
danditomaso
danditomaso requested changes Feb 4, 2025
View reviewed changes
Copy link
Collaborator

@danditomaso danditomaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed one of the useEffect's in src/components/Dialog/NodeDetailsDialog.tsx. You should be able to remove it without a problem, and it will avoid extra re-renders due to setting the device to state

src/components/Dialog/NodeDetailsDialog.tsx Outdated Show resolved Hide resolved
@danditomaso danditomaso self-requested a review February 4, 2025 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danditomaso danditomaso danditomaso approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request major change This is a major change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@KomelT @Hunter275 @danditomaso @dzienisz @caveman99