Skip to content

🌱 Use IRSO in e2e tests #2776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
adilGhaffarDev wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🌱 Use IRSO in e2e tests #2776

adilGhaffarDev wants to merge 1 commit into from

Conversation

@adilGhaffarDev
Copy link
Member

@adilGhaffarDev adilGhaffarDev commented Sep 11, 2025

What this PR does / why we need it:
Use IRSO in e2e tests
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@metal3-io-bot
Copy link
Contributor

metal3-io-bot commented Sep 11, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@metal3-io-bot metal3-io-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 11, 2025
@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 11, 2025
@metal3-io-bot metal3-io-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 11, 2025
@adilGhaffarDev
Copy link
Member Author

adilGhaffarDev commented Sep 12, 2025

/test metal3-centos-e2e-integration-test-main

@adilGhaffarDev
Copy link
Member Author

adilGhaffarDev commented Sep 15, 2025

/test metal3-centos-e2e-integration-test-main

@adilGhaffarDev
Copy link
Member Author

adilGhaffarDev commented Sep 15, 2025

/test metal3-centos-e2e-integration-test-main

1 similar comment
@adilGhaffarDev
Copy link
Member Author

adilGhaffarDev commented Sep 15, 2025

/test metal3-centos-e2e-integration-test-main

@adilGhaffarDev
Copy link
Member Author

adilGhaffarDev commented Sep 15, 2025

/test metal3-centos-e2e-integration-test-main

@adilGhaffarDev
Copy link
Member Author

adilGhaffarDev commented Sep 15, 2025

/test metal3-centos-e2e-integration-test-main

@adilGhaffarDev
Copy link
Member Author

adilGhaffarDev commented Sep 15, 2025

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

@adilGhaffarDev
Copy link
Member Author

adilGhaffarDev commented Sep 16, 2025

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

@adilGhaffarDev
Copy link
Member Author

adilGhaffarDev commented Sep 16, 2025

/test metal3-centos-e2e-integration-test-main

@adilGhaffarDev
Copy link
Member Author

adilGhaffarDev commented Sep 16, 2025

/test metal3-centos-e2e-integration-test-main

@adilGhaffarDev
Copy link
Member Author

adilGhaffarDev commented Sep 16, 2025

/test metal3-centos-e2e-integration-test-main

@metal3-io-bot metal3-io-bot added the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Sep 16, 2025
@adilGhaffarDev
Copy link
Member Author

adilGhaffarDev commented Dec 8, 2025

/test metal3-centos-e2e-integration-test-main
@kashifest i think we can merge this, I have not seen ipa-downloader failure since last 8 run.

Copilot AI reviewed Dec 8, 2025
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 40 out of 40 changed files in this pull request and generated 10 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@adilGhaffarDev
Copy link
Member Author

adilGhaffarDev commented Dec 8, 2025

/test metal3-centos-e2e-integration-test-main

@adilGhaffarDev
Copy link
Member Author

adilGhaffarDev commented Dec 8, 2025

/test metal3-centos-e2e-integration-test-main

@adilGhaffarDev
Copy link
Member Author

adilGhaffarDev commented Dec 8, 2025

/test metal3-centos-e2e-integration-test-main

@adilGhaffarDev
Copy link
Member Author

adilGhaffarDev commented Dec 8, 2025

/test metal3-centos-e2e-integration-test-main

1 similar comment
@adilGhaffarDev
Copy link
Member Author

adilGhaffarDev commented Dec 8, 2025

/test metal3-centos-e2e-integration-test-main

@adilGhaffarDev
Copy link
Member Author

adilGhaffarDev commented Dec 8, 2025

/test metal3-centos-e2e-integration-test-main

@adilGhaffarDev
Copy link
Member Author

adilGhaffarDev commented Dec 8, 2025

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main
/test metal3-e2e-clusterctl-upgrade-test-main

@adilGhaffarDev
Copy link
Member Author

adilGhaffarDev commented Dec 9, 2025

cc @kashifest @lentzi90 @peppi-lotta @Sunnatillo please review.
Now test is not failing at ipa downloader and passing tests consistently.

@tuminoid tuminoid requested a review from Copilot December 9, 2025 08:19
Copilot AI reviewed Dec 9, 2025
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 40 out of 40 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@adilGhaffarDev
Copy link
Member Author

adilGhaffarDev commented Dec 9, 2025

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

@peppi-lotta peppi-lotta mentioned this pull request Dec 10, 2025
Open
@peppi-lotta
Copy link
Member

peppi-lotta commented Dec 10, 2025

I read through your changes and LGTM. It looks to me like you are using irso the way at least I understand it's supposed to be used and code looks clean. Good job with this big change!

@metal3-io-bot metal3-io-bot added the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Dec 15, 2025
@adilGhaffarDev
Use IRSO in e2e tests
0463be9 
Signed-off-by: Muhammad Adil Ghaffar <[email protected]>
@metal3-io-bot metal3-io-bot removed the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Dec 16, 2025
@adilGhaffarDev
Copy link
Member Author

adilGhaffarDev commented Dec 16, 2025

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@honza honza Awaiting requested review from honza

@Rozzii Rozzii Awaiting requested review from Rozzii

@nuhakala nuhakala Awaiting requested review from nuhakala

@tuminoid tuminoid Awaiting requested review from tuminoid

Assignees

No one assigned

Labels

size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@adilGhaffarDev @metal3-io-bot @Rozzii @kashifest @peppi-lotta @tuminoid @nuhakala