Skip to content

🌱 Prepare main branch for relase-1.13 dev #3051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Sunnatillo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🌱 Prepare main branch for relase-1.13 dev #3051

Sunnatillo wants to merge 1 commit into from

Conversation

@Sunnatillo
Copy link
Member

@Sunnatillo Sunnatillo commented Dec 23, 2025 •
edited
Loading

This PR:

  • Adds clusterctl-settings, e2e config
  • Updates the available test triggers of different branches, removes deprecated triggers
  • Updates the support matrix in the README
  • Add release-1.12 e2e template generation to Makefile

What this PR does / why we need it:

Fixes #

Checklist:

  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • E2E tests have been added, if necessary.
  • Integration tests have been added, if necessary.

@metal3-io-bot
Copy link
Contributor

metal3-io-bot commented Dec 23, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign tuminoid for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 23, 2025
@Sunnatillo Sunnatillo mentioned this pull request Dec 23, 2025
Open
4 tasks
@Sunnatillo Sunnatillo force-pushed the Sunnatillo/prepare-release-v1.13 branch from f929d08 to 27607e2 Compare December 23, 2025 10:55
@Sunnatillo
Copy link
Member Author

Sunnatillo commented Dec 23, 2025

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

@Sunnatillo
Copy link
Member Author

Sunnatillo commented Dec 23, 2025

/cc @lentzi90 @adilGhaffarDev @peppi-lotta

adilGhaffarDev
adilGhaffarDev reviewed Dec 23, 2025
View reviewed changes
test/e2e/config/e2e_conf.yaml Outdated
versions:
- name: "v1.12.99"
- name: "v1.13.99"
# Switch back to nightly builds once 1.12 stable is out. ("https://storage.googleapis.com/k8s-staging-cluster-api/components/nightly_main_${DATE}/bootstrap-components.yaml"
Copy link
Member

@adilGhaffarDev adilGhaffarDev Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can remove this comment now

Copy link
Member

@adilGhaffarDev adilGhaffarDev Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also in other places in this file.

Copy link
Member Author

@Sunnatillo Sunnatillo Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@Sunnatillo
Prepare main branch for relase-1.13 dev
3ee2c2d 
This commit:
 - Adds clusterctl-settings, e2e config
 - Updates the available test triggers of different branches, removes
   deprecated triggers
 - Updates the support matrix in the README
 - Add release-1.12 e2e template generation to Makefile

Signed-off-by: Sunnatillo <[email protected]>
@Sunnatillo Sunnatillo force-pushed the Sunnatillo/prepare-release-v1.13 branch from 27607e2 to 3ee2c2d Compare December 23, 2025 11:15
@Sunnatillo
Copy link
Member Author

Sunnatillo commented Dec 23, 2025

/test metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main

@adilGhaffarDev
Copy link
Member

adilGhaffarDev commented Dec 23, 2025

are you going to update clusterctl tests in separate PR?

adilGhaffarDev
adilGhaffarDev reviewed Dec 23, 2025
View reviewed changes
scripts/ci-e2e.sh
BMO_OVERLAYS=(
"${REPO_ROOT}/test/e2e/data/bmo-deployment/overlays/release-0.9"
"${REPO_ROOT}/test/e2e/data/bmo-deployment/overlays/release-0.10"
"${REPO_ROOT}/test/e2e/data/bmo-deployment/overlays/release-0.11"
Copy link
Member

@adilGhaffarDev adilGhaffarDev Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add 0.12 bmo
"${REPO_ROOT}/test/e2e/data/bmo-deployment/overlays/release-0.12"

Copy link
Member

@adilGhaffarDev adilGhaffarDev Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets remove "${REPO_ROOT}/test/e2e/data/bmo-deployment/overlays/release-0.9"

adilGhaffarDev
adilGhaffarDev reviewed Dec 23, 2025
View reviewed changes
scripts/ci-e2e.sh
"${REPO_ROOT}/test/e2e/data/ironic-deployment/overlays/release-27.0"
"${REPO_ROOT}/test/e2e/data/ironic-deployment/overlays/release-29.0"
"${REPO_ROOT}/test/e2e/data/ironic-deployment/overlays/release-31.0"
"${REPO_ROOT}/test/e2e/data/ironic-deployment/overlays/release-32.0"
Copy link
Member

@adilGhaffarDev adilGhaffarDev Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add release-33 ironic
"${REPO_ROOT}/test/e2e/data/ironic-deployment/overlays/release-33.0"

Copy link
Member

@adilGhaffarDev adilGhaffarDev Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets get rid of
"${REPO_ROOT}/test/e2e/data/ironic-deployment/overlays/release-27.0"
"${REPO_ROOT}/test/e2e/data/ironic-deployment/overlays/release-29.0"

adilGhaffarDev
adilGhaffarDev reviewed Dec 23, 2025
View reviewed changes
test/e2e/config/e2e_conf.yaml
IRONIC_RELEASE_29.0: "data/ironic-deployment/overlays/release-29.0"
IRONIC_RELEASE_31.0: "data/ironic-deployment/overlays/release-31.0"
IRONIC_RELEASE_32.0: "data/ironic-deployment/overlays/release-32.0"
IRONIC_RELEASE_33.0: "data/ironic-deployment/overlays/release-32.0"
Copy link
Member

@adilGhaffarDev adilGhaffarDev Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
IRONIC_RELEASE_33.0: "data/ironic-deployment/overlays/release-32.0"
IRONIC_RELEASE_33.0: "data/ironic-deployment/overlays/release-33.0"

adilGhaffarDev
adilGhaffarDev reviewed Dec 23, 2025
View reviewed changes
test/e2e/config/e2e_conf.yaml
IRONIC_RELEASE_LATEST: "data/ironic-deployment/overlays/release-latest"
BMO_RELEASE_0.9: "data/bmo-deployment/overlays/release-0.9"
BMO_RELEASE_0.10: "data/bmo-deployment/overlays/release-0.10"
BMO_RELEASE_0.11: "data/bmo-deployment/overlays/release-0.11"
Copy link
Member

@adilGhaffarDev adilGhaffarDev Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

following is missing.
BMO_RELEASE_0.12: "data/bmo-deployment/overlays/release-0.12"

@adilGhaffarDev
Copy link
Member

adilGhaffarDev commented Dec 23, 2025

capi/v1.13/metadata.yaml in tests is missing.

@metal3-io-bot
Copy link
Contributor

metal3-io-bot commented Dec 23, 2025 •
edited
Loading

@Sunnatillo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
metal3-ubuntu-e2e-integration-test-main 3ee2c2d link true /test metal3-ubuntu-e2e-integration-test-main
metal3-centos-e2e-integration-test-main 3ee2c2d link true /test metal3-centos-e2e-integration-test-main

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fmuyassarov fmuyassarov Awaiting requested review from fmuyassarov

@lentzi90 lentzi90 Awaiting requested review from lentzi90

@peppi-lotta peppi-lotta Awaiting requested review from peppi-lotta

1 more reviewer

@adilGhaffarDev adilGhaffarDev adilGhaffarDev left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Sunnatillo @metal3-io-bot @adilGhaffarDev