[CLANG_CL] Fix clang-cl warnings #5660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add -Wno used for clang in linux build. Fix -Wimplicit-fallthrough -Wconstant-logical-operand (Thanks patch from Chris) -Wunused-function -Wunused-variable -Wtrigraphs Still more warnings to be fixed.
python3kgae
requested review from
llvm-beanz and
pow2clk
and removed request for
llvm-beanz
pow2clk
reviewed
Sep 7, 2023
| { L"filename2.fx", STGTY_STREAM, { 0, 0 }, { 0, 0 }, { 0, 0 }, { 0, 0 }, 0, 0, GUID_NULL, 0, 0 } | ||
| }; | ||
| unsigned testCount = (unsigned)_countof(items); | ||
| STATSTG items[] = {{const_cast<wchar_t *>(L"filename.hlsl"), |
There was a problem hiding this comment.
It's unfortunate that the filename in STATSTG isn't const. I don't imagine any of the usages will change that string. If they do, trying to change a literal would be very bad. I would still prefer creating a local editable allocation initialized to this string value rather than passing in a literal as non-const.
Only add __attribute__((fallthrough)) for LLVM_C_FALLTHROUGH. Enable warnings explicitly. Add const instead of use const_cast.
pow2clk
reviewed
Sep 8, 2023
| // First OpCode token | ||
| m_pCurrentToken = (CShaderToken*)&pBuffer[2]; | ||
| m_pCurrentToken = const_cast<CShaderToken *>(&pBuffer[2]); |
There was a problem hiding this comment.
I don't know why these three const_casts are necessary. Since we're assigning to constant pointers, why cast to non constant pointers before that assignment?
There was a problem hiding this comment.
:( Missed after mark m_pCurrentToken to const.
Fixed.
tex3d
approved these changes
Sep 14, 2023
llvm-beanz
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add -Wno-unused-parameter -Wno-unknown-pragams -Wno-switch which are enabled for clang in linux build.
Fix
-Wimplicit-fallthrough
-Wconstant-logical-operand (Thanks patch from Chris)
-Wunused-function
-Wunused-variable
-Wtrigraphs
-Wnonportable-include-path
Still more warnings to be fixed.