Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLANG_CL] Fix clang-cl warnings #5660

Merged
merged 9 commits into from
Sep 14, 2023
Merged

[CLANG_CL] Fix clang-cl warnings #5660

merged 9 commits into from
Sep 14, 2023

Commits on Sep 6, 2023

  1. [CLANG_CL] Fix clang-cl warnings 

    Add -Wno used for clang in linux build.
Fix
-Wimplicit-fallthrough
-Wconstant-logical-operand (Thanks patch from Chris)
-Wunused-function
-Wunused-variable
-Wtrigraphs

Still more warnings to be fixed.
    @python3kgae
    python3kgae committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    ae00438 View commit details
    Browse the repository at this point in the history

  2. Missing fix.

    @python3kgae
    python3kgae committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    a00570f View commit details
    Browse the repository at this point in the history

  3. Fix error 'fallthrough' attribute is only allowed on emtpy statement.

    @python3kgae
    python3kgae committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    5f1bf32 View commit details
    Browse the repository at this point in the history

  4. Another LLVM_FALLTHROUGH with ;

    @python3kgae
    python3kgae committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    35fdbb7 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2023

  1. Avoid using c++20 feature.

    @python3kgae
    python3kgae committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    24583aa View commit details
    Browse the repository at this point in the history

  2. Use LLVM_FALLTHROUGH instead of reorder default.

    @python3kgae
    python3kgae committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    4fad7e9 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2023

  1. Use LLVM_C_FALLTHROUGH to c. 

    Only add __attribute__((fallthrough)) for LLVM_C_FALLTHROUGH.

Enable warnings explicitly.
Add const instead of use const_cast.
    @python3kgae
    python3kgae committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    4d0007f View commit details
    Browse the repository at this point in the history

  2. Add default empty LANGOPT_BOOL.

    @python3kgae
    python3kgae committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    13086a8 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2023

  1. Remove unnecessary const_cast.

    @python3kgae
    python3kgae committed Sep 9, 2023
    Configuration menu
    Copy the full SHA
    7da2cde View commit details
    Browse the repository at this point in the history