Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix linter #1042

Merged
merged 5 commits into from
Mar 14, 2024
Merged

Fix linter #1042

merged 5 commits into from
Mar 14, 2024

Conversation

shiranr
Copy link
Contributor

@shiranr shiranr commented Mar 14, 2024

fix linter and our PR template

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 14, 2024 •
edited
Loading

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 2 0 0.03s
⚠️ MARKDOWN markdownlint 257 3 6.18s
⚠️ MARKDOWN markdown-table-formatter 257 1 0.57s
✅ MDLINKCHECK linkcheck 257 0 11.32s
✅ SPELL cspell 268 0 11.62s
✅ YAML prettier 10 0 1.47s
✅ YAML yamllint 10 0 0.48s

See detailed report in MegaLinter reports

You could have same capabilities but better runtime performances if you request a new MegaLinter flavor.

MegaLinter is graciously provided by OX Security

balteravishay
balteravishay approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@balteravishay balteravishay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nit suggestion. approving

@shiranr shiranr requested a review from tompaana March 14, 2024 14:44
nyouens
nyouens approved these changes Mar 14, 2024
View reviewed changes
Copy link

@nyouens nyouens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@shiranr shiranr merged commit fe76ec5 into main Mar 14, 2024
2 checks passed
@shiranr shiranr deleted the fix-linter branch March 14, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TessFerrandez TessFerrandez TessFerrandez approved these changes

@balteravishay balteravishay balteravishay approved these changes

@nyouens nyouens nyouens approved these changes

@tompaana tompaana Awaiting requested review from tompaana

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shiranr @TessFerrandez @balteravishay @nyouens