Skip to content

Fix linter #1042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 14, 2024
Merged

Fix linter #1042

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2c05f7c
remove none existing link
shiranr Mar 14, 2024
7704b78
fix the PR template
shiranr Mar 14, 2024
20b7a6c
fix rules for code review
shiranr Mar 14, 2024
be66a4b
Change megalinter to only go through the changed files and not entier…
shiranr Mar 14, 2024
5f2887c
Update .github/pull_request_template.md
shiranr Mar 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
/docs/* @tessferrandez @shiranr @tompaana @nyouens

* @tessferrandez @shiranr @nyouens

/docs/* @tessferrandez @shiranr @tompaana


3 changes: 1 addition & 2 deletions .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,7 @@
- [ ] No confidential information
- [ ] No duplicated content
- [ ] Labeled appropriately
- [ ] Added 2 reviewers
- [ ] No lint errors
- [ ] This PR was reviewed by at least one subject matter expert
- [ ] No lint check errors related to your changes

> Note: You may see link check errors on pages you have not touched. This is normal, and due to either broken links or sites that reject link checker bots. The reviewer will help you get to a green state on these.
2 changes: 1 addition & 1 deletion .mega-linter.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ SHOW_ELAPSED_TIME: true
FILEIO_REPORTER: false
PARALLEL: true
GITHUB_STATUS_REPORTER: true
VALIDATE_ALL_CODEBASE: true
VALIDATE_ALL_CODEBASE: false
LOG_LEVEL: WARNING
MARKDOWN_MARKDOWN_LINK_CHECK_ARGUMENTS: "-q"
# DISABLE_ERRORS: true # Uncomment if you want MegaLinter to detect errors but not block CI to pass
Expand Down
1 change: 0 additions & 1 deletion docs/observability/tools/KubernetesDashboards.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,4 +36,3 @@ There are currently several UI dashboards available to monitor your applications
## References

- [Alternatives to Kubernetes Dashboard](https://octopus.com/blog/alternative-kubernetes-dashboards)
- [Prometheus and Grafana with Kubernetes](https://tanzu.vmware.com/developer/guides/kubernetes/observability-prometheus-grafana-p1/)
Loading