Fix deps of skipped ports getting added to the CI run #1821
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillyONeal
reviewed
Oct 21, 2025
| std::string msg; | ||
|
|
||
| // First, print ports that were excluded early (before dependency resolution) | ||
| for (const auto& excluded_spec : ports_to_exclude) |
Member
There was a problem hiding this comment.
This is a good idea I missed in my version of the same #1822 (comment)
Member
There was a problem hiding this comment.
In #1822 (comment) in addition to fixing this problem I also fixed the "Summary" at the end to properly note that these were EXCLUDED
Thomas1664
reviewed
Oct 22, 2025
Contributor
Author
|
should this be closed in favor of #1822 ? |
Member
Probably not, since I used ideas in here and am still looking at it a bit. Hope to have that ready for review with more tests and the edge cases the team asked me to investigate tomorrow. |
Member
|
Closing this as its effect was merged into #1822 |
Neumann-A
deleted the
fix_features_of_skipped_deps_getting_added_to_ci
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provided by Claude Sonnet 4.5 after longer discussions.
What I like:
FilteredPortFileProvider(damn was unnecessary)What I don like:
alternative to #1822