-
Notifications
You must be signed in to change notification settings - Fork 335
Fix deps of skipped ports getting added to the CI run #1821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Neumann-A
wants to merge
10
commits into
microsoft:main
from
Neumann-A:fix_features_of_skipped_deps_getting_added_to_ci
Closed
Changes from 4 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
5af3e9f
Fix deps of skipped ports getting added to the CI run
Neumann-A ddcf6e4
Fix testing installed vs plan
Neumann-A 403ab76
More test fixes
Neumann-A 9655629
Remove filtered provider it is not necessary
Neumann-A 658c1e7
rename test stuff to be more generic
Neumann-A 4db2979
Ai is a bit too verbose.
Neumann-A 0242604
Rename and Refactor
Neumann-A 1936745
remove unused file
Neumann-A a699bd2
forget to tell AI to run clang format for me
Neumann-A 924a638
USe a string literal for the dummy abi
Neumann-A File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| # CI Baseline for testing early filtering | ||
| # qtwayland-test should be skipped on all triplets | ||
| qtwayland-test:x86-windows=skip | ||
| qtwayland-test:x64-windows=skip | ||
| qtwayland-test:arm64-windows=skip | ||
| qtwayland-test:x64-linux=skip | ||
| qtwayland-test:arm64-linux=skip | ||
| qtwayland-test:x64-osx=skip | ||
| qtwayland-test:arm64-osx=skip |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| # CI Feature Baseline for testing | ||
| # This file contains features that should be skipped during CI testing | ||
|
|
||
| # qtbase-test port has 'wayland' feature marked as skip | ||
| qtbase-test[wayland] = skip | ||
|
|
||
| # qtwayland-test should cascade (skip if any dependency is skipped) | ||
| qtwayland-test = cascade |
7 changes: 7 additions & 0 deletions
7
azure-pipelines/e2e-ports/ci-feature-baseline/qtbase-test/portfile.cmake
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| vcpkg_minimum_required(VERSION 2024-11-01) | ||
|
|
||
| message(STATUS "Installing qtbase-test") | ||
|
|
||
| file(WRITE "${CURRENT_PACKAGES_DIR}/share/${PORT}/copyright" "Test port") | ||
|
|
||
| set(VCPKG_POLICY_EMPTY_PACKAGE enabled) |
10 changes: 10 additions & 0 deletions
10
azure-pipelines/e2e-ports/ci-feature-baseline/qtbase-test/vcpkg.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| { | ||
| "name": "qtbase-test", | ||
| "version": "1.0.0", | ||
| "description": "Test port simulating qtbase with wayland feature", | ||
| "features": { | ||
| "wayland": { | ||
| "description": "Wayland support (should be skipped on macOS in CI)" | ||
| } | ||
| } | ||
| } |
7 changes: 7 additions & 0 deletions
7
azure-pipelines/e2e-ports/ci-feature-baseline/qtwayland-test/portfile.cmake
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| vcpkg_minimum_required(VERSION 2024-11-01) | ||
|
|
||
| message(STATUS "Installing qtwayland-test") | ||
|
|
||
| file(WRITE "${CURRENT_PACKAGES_DIR}/share/${PORT}/copyright" "Test port") | ||
|
|
||
| set(VCPKG_POLICY_EMPTY_PACKAGE enabled) |
11 changes: 11 additions & 0 deletions
11
azure-pipelines/e2e-ports/ci-feature-baseline/qtwayland-test/vcpkg.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| { | ||
| "name": "qtwayland-test", | ||
| "version": "1.0.0", | ||
| "description": "Test port simulating qtwayland that depends on qtbase[wayland]", | ||
| "dependencies": [ | ||
| { | ||
| "name": "qtbase-test", | ||
| "features": ["wayland"] | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good idea I missed in my version of the same #1822 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In #1822 (comment) in addition to fixing this problem I also fixed the "Summary" at the end to properly note that these were
EXCLUDED