Skip to content

Optimize join tables from different databases#412

Merged
ea-rus merged 5 commits intostagingfrom
optimize-join
Nov 6, 2024
Merged

Optimize join tables from different databases#412
ea-rus merged 5 commits intostagingfrom
optimize-join

Conversation

@ea-rus
Copy link
Collaborator

@ea-rus ea-rus commented Oct 31, 2024

For the query:

select * from table1 t1
join table2 t2 on t1.id=t2.id

After getting data from t1, it is extracting unique ids from this data and uses this query to get data from second table:

select * from table2 where id in (<ids from previous step>)

Fixes: https://linear.app/mindsdb/issue/BE-436/optimize-join

@github-actions
Copy link

github-actions bot commented Nov 2, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
mindsdb_sql
   __about__.py10100%1–10
   __init__.py1292283%43, 47, 93, 110, 134–153, 160–161, 178
mindsdb_sql/parser
   lexer.py165199%243
   logger.py19479%14, 17, 23, 26
   parser.py4603193%48, 53, 73, 77, 81, 87, 91–93, 121–128, 182, 199, 249, 253, 317, 346–347, 367, 378, 491, 526, 557, 567, 581, 662
   utils.py46491%73–79
mindsdb_sql/parser/ast
   base.py36781%13, 28, 31, 49–52
   create.py761087%7–8, 23, 28, 91–96
   drop.py52296%10, 13
   insert.py63494%39–41, 46
   show.py48198%18
   update.py53591%40–42, 75–76
mindsdb_sql/parser/ast/select
   case.py32294%19, 22
   constant.py36197%23
   data.py11282%15, 19
   identifier.py64789%43, 80–85
   native_query.py13192%25
   operation.py131497%56, 65, 168, 187
   parameter.py11191%10
   select.py97397%148–153
   star.py12283%8–9
   union.py23196%18
mindsdb_sql/parser/dialects/mindsdb
   knowledge_base.py46198%79
   lexer.py2622192%343, 345, 347, 359, 361, 363, 369–387
   parser.py10272697%118, 122, 261, 286, 383, 569, 586, 610–611, 807, 861, 938, 1065, 1075, 1113–1114, 1143, 1154, 1236, 1299, 1360, 1844, 1852, 1905–1908
mindsdb_sql/parser/dialects/mysql
   lexer.py23674%16, 18, 20, 32, 34, 36
   parser.py6132496%131, 133, 226–227, 326, 356, 373, 423, 427, 501, 511, 549–550, 570, 581, 702, 730, 735–737, 741, 758, 907, 1051
   show_index.py171135%10–12, 15–23, 26–27
mindsdb_sql/planner
   plan_join.py3701795%144, 152, 186, 195, 222, 226, 315, 365, 383, 395–396, 447, 475, 481, 498, 521, 523
   plan_join_ts.py1791094%53, 60, 83–84, 129, 181, 185, 193, 268, 335
   query_plan.py22864%13–21, 30
   query_planner.py4146784%41–42, 65–66, 75, 166, 309, 327–329, 336, 437, 465–543, 586–587, 600, 626, 691, 721, 747, 772–774
   query_prepare.py2846179%76, 78, 86–116, 227, 249, 272, 315, 336, 360, 389–443, 446–452, 483, 496–498, 507, 526
   step_result.py14286%7, 12
   steps.py1581690%12, 17, 25, 30–32, 51–53, 61–64, 90–92
   ts_utils.py67691%59, 61, 83–86, 90
   utils.py2422789%60, 106, 112, 127, 139, 151, 154, 166, 194, 207, 222, 228, 233, 240, 242, 247, 260, 265, 271, 277, 291, 308, 338–339, 350–351, 366
mindsdb_sql/render
   sqlalchemy_render.py4627085%56, 91, 93, 105, 110, 127, 129, 131, 133, 195, 212–213, 224–225, 243, 273, 275, 286, 323, 337, 343, 394, 459–463, 474–478, 508, 523, 537, 542, 555–556, 559–560, 567, 590–601, 621, 654–678, 701, 707, 747–750, 771–774
TOTAL664549893% 

Tests Skipped Failures Errors Time
684 1 💤 0 ❌ 0 🔥 25.311s ⏱️

@ea-rus ea-rus marked this pull request as ready for review November 2, 2024 17:19
@ea-rus ea-rus merged commit 5525c2c into staging Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: merged

Development

Successfully merging this pull request may close these issues.

1 participant