Upgrade "actions/upload-artifact" GitHub Action #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
approved these changes
Oct 31, 2024
stof
requested changes
Oct 31, 2024
.github/workflows/tests.yml
Outdated
| @@ -84,7 +84,7 @@ jobs: | |||
|
|
|||
| - name: Archive logs artifacts | |||
| if: ${{ failure() }} | |||
| uses: actions/upload-artifact@v2 | |||
| uses: actions/upload-artifact@v4 | |||
| with: | |||
| name: logs_php-${{ matrix.php }} | |||
There was a problem hiding this comment.
the name needs to be update to also include other elements of the matrix, to avoid having multiple jobs uploading with the same name, which is forbidden in v4
There was a problem hiding this comment.
Done.
The build fails. Not sure if it passed in recent couple of years, while GitHub Actions was preserving past build logs.
|
I think the purpose of this PR is fulfilled - the build now works and each of the reported errors can be addressed as a separate PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading "actions/upload-artifact" GitHub Action, because the v2 is used, which causes the build to fail https://github.com/minkphp/MinkZombieDriver/actions/runs/11610353612 with this message:
P.S.
While I'm at it I've decided to upgrade other used GitHub Actions as well.