Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade "actions/upload-artifact" GitHub Action #205

Merged
merged 3 commits into from
Oct 31, 2024
Merged

Upgrade "actions/upload-artifact" GitHub Action #205

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aae94db
Upgrade "actions/upload-artifact" GitHub Action
aik099 Oct 31, 2024
8865704
Upgrade other GitHub Actions
aik099 Oct 31, 2024
b84613d
Include all matrix elements in the artifact filename
aik099 Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ jobs:

- name: Archive logs artifacts
if: ${{ failure() }}
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v4
with:
name: logs_php-${{ matrix.php }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the name needs to be update to also include other elements of the matrix, to avoid having multiple jobs uploading with the same name, which is forbidden in v4

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

The build fails. Not sure if it passed in recent couple of years, while GitHub Actions was preserving past build logs.

path: |
Expand Down
Loading