build(#10336): Storybook & Chromatic & msw #10365

acid-chicken · 2023-03-19T13:24:49Z

#10336 セットアップ作業用ブランチ

実行方法

Universal

Setup

cd path/to/packages/misskey-js
pnpm build
cd path/to/packages/frontend
pnpm tsc -p .storybook && (node .storybook/preload-locale.js & node .storybook/preload-theme.js)

Run

cd path/to/packages/frontend
node .storybook/generate.js && pnpm storybook dev

macOS & Linux

Setup

cd path/to/packages/misskey-js
pnpm build

Run

cd path/to/packages/frontend
pnpm storybook-dev

codecov · 2023-03-19T13:28:21Z

Codecov Report

Merging #10365 (b91d831) into develop (58f3a2e) will increase coverage by 0.00%.
The diff coverage is 96.22%.

@@           Coverage Diff            @@
##           develop   #10365   +/-   ##
========================================
  Coverage    75.23%   75.24%           
========================================
  Files          883      883           
  Lines        86686    86716   +30     
  Branches      5903     5907    +4     
========================================
+ Hits         65219    65249   +30     
  Misses       21467    21467

Impacted Files	Coverage Δ
packages/frontend/src/components/MkUrlPreview.vue	`92.20% <0.00%> (ø)`
packages/frontend/src/components/global/MkAcct.vue	`100.00% <ø> (ø)`
packages/frontend/src/scripts/achievements.ts	`96.43% <66.66%> (+0.02%)`	⬆️
packages/frontend/src/components/MkContextMenu.vue	`100.00% <100.00%> (ø)`
packages/frontend/src/components/MkMenu.vue	`100.00% <100.00%> (ø)`
packages/frontend/src/components/global/MkAd.vue	`100.00% <100.00%> (ø)`
...ckages/frontend/src/components/global/MkAvatar.vue	`97.70% <100.00%> (+<0.01%)`	⬆️
...ages/frontend/src/components/global/MkEllipsis.vue	`100.00% <100.00%> (ø)`
...kages/frontend/src/components/global/MkLoading.vue	`100.00% <100.00%> (ø)`
...ontend/src/components/global/MkPageHeader.tabs.vue	`100.00% <100.00%> (ø)`
... and 1 more

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

acid-chicken · 2023-03-20T07:16:36Z

packages/frontend/.storybook/.gitignore

現時点ではこのファイルに書いてあるコマンドでストーリーを生成してから pnpm storybook dev して Storybook の画面を開くことができる

[vite] Internal server error: Failed to resolve import "../node_modules/storybook-addon-misskey-theme/preview" from "..\..\..\..\..\..\virtual:\@storybook\builder-vite\vite-app.js". Does the file exist?
が出た

CI は回ってるし謎
あとで調査します

Windows 環境で再現した

@syuilo 多分直った

Please don't submit reviews blindly.

same

…to storybook

… storybook

acid-chicken · 2023-04-03T05:06:01Z

とりあえずこの PR でやっておきたいことは完全に終わった（のでレビューお願いします）

packages/misskey-js/package.json

packages/frontend/src/components/MkMenu.vue

syuilo · 2023-04-03T05:59:30Z

packages/frontend/src/pages/user/activity.following.vue

@@ -77,7 +77,7 @@ async function renderChart() {
 			barPercentage: 0.7,
 			categoryPercentage: 0.7,
 			fill: true,
-		} satisfies ChartDataset, extra);
+		}, extra);


satisfies使えないの悲しいわね

benjamn/ast-types#935

コメントでsatisfies使いたいけど使えない旨を残しておいてもらえると助かる

done @ b91d831

syuilo · 2023-04-04T00:38:39Z

🙏🏻🙏🏻🙏🏻

github-actions bot added the packages/frontend Client side specific issue/PR label Mar 19, 2023

build(#10336): init

1dfcca7

acid-chicken force-pushed the storybook branch from 9d62184 to 1dfcca7 Compare March 19, 2023 13:25

acid-chicken added 5 commits March 19, 2023 22:31

fix(#10336): invalid name conversion

91e0e49

build(#10336): load locales and vite config

0dcb99d

refactor(#10336): remove unused imports

a19c560

build(#10336): separate definitions and generated codes

6e21147

refactor(#10336): remove hatches

be7b71a

acid-chicken commented Mar 20, 2023

View reviewed changes

acid-chicken changed the title ~~build(#10336): Storybook & Chromatic~~ build(#10336): Storybook & Chromatic & msw Mar 20, 2023

acid-chicken added 2 commits March 20, 2023 16:27

refactor(#10336): module semantics

3907cb5

refactor(#10336): remove unused common preferences

ca7d208

acid-chicken force-pushed the storybook branch 2 times, most recently from 9525989 to 59865c3 Compare March 20, 2023 07:33

fix: typo

2ec608f

acid-chicken force-pushed the storybook branch from 59865c3 to 2ec608f Compare March 20, 2023 07:34

build(#10336): mock assets

2eecb8e

acid-chicken added 9 commits March 20, 2023 23:07

build(#10336): impl SatisfiesExpression

bdbbb92

build(#10336): control themes

0ac4d74

refactor(#10336): semantics

bf527cd

build(#10336): make .storybook as an individual TypeScript project

cc3fbef

style(#10336): use single quote

49f8bb4

build(#10336): avoid intrinsic component names

5ced8ae

chore: suppress linter

1d0ca7e

style: typing

bf5fff8

build(#10336): update dependencies

c2d8759

docs: note about Storybook

bd7cc6a

misskey-dev deleted a comment from github-actions bot Apr 2, 2023

acid-chicken added 4 commits April 3, 2023 02:09

chore: void

36e8988

Merge branch 'develop' into storybook

a61fe90

ci(#10336): change parameters

3ab2a00

Merge branch 'storybook' of https://github.com/misskey-dev/misskey in…

423a67f

…to storybook

misskey-dev deleted a comment from github-actions bot Apr 2, 2023

acid-chicken added 9 commits April 3, 2023 10:50

docs(#10336): update CONTRIBUTING

902d7c5

docs(#10336): note about meta overriding and etc.

4f7ba29

ci(#10336): use Chromatic for checks

b1b871a

Merge branch 'storybook' of https://github.com/misskey-dev/misskey in…

b303a80

…to storybook

ci(#10336): use pull_request instead of pull_request_target for now

9b00424

Merge branch 'develop' of https://github.com/misskey-dev/misskey into…

8d90e88

… storybook

ci(#10336): use exitOnceUploaded

2acb655

ci(#10336): reuse built storybook

b3b64d8

ci(#10336): back to pull_request_target

211682d

syuilo reviewed Apr 3, 2023

View reviewed changes

packages/misskey-js/package.json Outdated Show resolved Hide resolved

chore: unused dependencies

38b9fc4

syuilo reviewed Apr 3, 2023

View reviewed changes

packages/frontend/src/components/MkMenu.vue Outdated Show resolved Hide resolved

style(#10336): reduce prettier indents

14591aa

syuilo reviewed Apr 3, 2023

View reviewed changes

style: note about TSSatisfiesExpression

b91d831

syuilo merged commit 38d0b62 into develop Apr 4, 2023

syuilo deleted the storybook branch April 4, 2023 00:38

acid-chicken removed the request for review from EbiseLutica April 4, 2023 04:57

acid-chicken mentioned this pull request Apr 4, 2023

build(#10336): upgrade Storybook to v7 #10466

Merged

4 tasks

acid-chicken mentioned this pull request Dec 26, 2023

refactor: paginationの型を明示する #12809

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build(#10336): Storybook & Chromatic & msw #10365

build(#10336): Storybook & Chromatic & msw #10365

acid-chicken commented Mar 19, 2023 •

edited

Loading

codecov bot commented Mar 19, 2023 •

edited

Loading

acid-chicken Mar 20, 2023

syuilo Apr 2, 2023

acid-chicken Apr 2, 2023

acid-chicken Apr 2, 2023

acid-chicken Apr 2, 2023

acid-chicken commented Apr 3, 2023 •

edited

Loading

syuilo Apr 3, 2023

acid-chicken Apr 3, 2023

syuilo Apr 3, 2023

acid-chicken Apr 3, 2023

syuilo commented Apr 4, 2023

build(#10336): Storybook & Chromatic & msw #10365

build(#10336): Storybook & Chromatic & msw #10365

Conversation

acid-chicken commented Mar 19, 2023 • edited Loading

実行方法

Universal

Setup

Run

macOS & Linux

Setup

Run

codecov bot commented Mar 19, 2023 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

acid-chicken commented Apr 3, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

syuilo commented Apr 4, 2023

acid-chicken commented Mar 19, 2023 •

edited

Loading

codecov bot commented Mar 19, 2023 •

edited

Loading

acid-chicken commented Apr 3, 2023 •

edited

Loading