Server rendering for homepage, units and topics listing pages #1847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge branch 'main' into jk/5919-prefetch-mechanism
ChristopherChudzicki
approved these changes
Nov 25, 2024
|
I don't think so given they're configuring cache behavior and retry etc, whereas on the server our query client is throwaway at the point we dehydrate for each request. It would be useful though to have a server side query client singleton that is scoped to the request. Next.js doesn't seem to have any way to access the request object outside of the middleware file to code for the request/response lifecycle. |
jonkafton
added a commit
that referenced
this pull request
Dec 2, 2024
mbertrand
pushed a commit
that referenced
this pull request
Dec 2, 2024
* Warn on API calls during initial render not prefetched * Full prefetch for homepage (commented) * Prefetch utility * Check for queries prefetched that are not needed during render and warn * No need to stringify * Replace useQuery overrides with decoupled cache check (wip) * Observer count for unnecessary prefetch warnings * Remove useQuery override * Test prefetch warnings * Remove inadvertent/unnecessary diff * Remove comments * Prefetch homepage. Invalidate learning resource cache items * Remove comment * Update comment * Temp remove featured resource list shuffle * Remove unused * Prefetch calls * Prefetch topics page * Rename key factory re-exports * Units page prefetch * Single request for all unit channel details * Update unit listing page tests * Page arg types * Optional route params * Remove comment * Remove unused * Remove comment * Reinstate featured list shuffle and remove cache invalidation to refetch resources for user * Add news to server render
mbertrand
pushed a commit
that referenced
this pull request
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Closes:
Next.js: Homepage: Prefetch API calls #5920
Next.js: Topics, Units and Channels pages: Prefetch API calls #6036
Description (What does it do?)
This PR reinstates #1822, which was approved/merged but reverted as it included cache invalidation for learning resources to refetched them in the client to get the list memberships that did not work for all cases. This PR removes the need for it: #1846 as it fetches memberships independently from the learning resources.
Homepage
Makes API calls needed to render homepage learning resources on the server so that these prerender:
Unit Listing page /units
Updates to make a single call
/api/v0/channels/?channel_type=unit, replacing calls to each channel detail page in the unit cards. Prefetches channels list and count by unit.Topics Listing page /topics
Prefetches topics list and counts by topic.
How can this be tested?
These routes should server render all public content without any prefetch mismatch warnings in the browser console:
Pages should render on first load with content with JavaScript disabled in the dev tools debugger settings.
Additional Context
Also adds reusable server PageParams type and cleans up the api key factory imports.