PYTHON-4530 - Move synchronized test code into top-level test directory #1718
+851
−3,805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoahStapp
changed the title
ShaneHarvey
reviewed
Jul 1, 2024
test/shared.py
Outdated
| @@ -0,0 +1,367 @@ | |||
| # Copyright 2010-present MongoDB, Inc. | |||
There was a problem hiding this comment.
Any alternative names for this file? “Shared.py” is pretty generic.
There was a problem hiding this comment.
What if we combine test/utils.py and this new file? Having multiple files that have effectively the same purpose seems unnecessary.
There was a problem hiding this comment.
Renamed to test/helpers.py for now, we can revisit down the road.
This was referenced Jul 1, 2024
blink1073
reviewed
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once all the tests are converted, we will move them in a single commit to
test/synchronous.