Bugfix: Site support form success message is shown below blocks or advert tiles on frontpage, resolves #488 #1082
Conversation
scha-ms
changed the title
…vert tiles on frontpage, resolves moodle-an-hochschulen#488
CHANGES.md
Outdated
|
|
||
| ### Unreleased | ||
|
|
||
| * 2025-10-24 - Bugfix: Site support form success message is shown below blocks or advert tiles on frontpage, resolves #488 |
There was a problem hiding this comment.
Changelog entries with bug fixes should be formulated in the past tense, if possible.
I will fix that in a review changes commit.
version.php
Outdated
|
|
||
| $plugin->component = 'theme_boost_union'; | ||
| $plugin->version = 2025041428; | ||
| $plugin->version = 2025041429; |
There was a problem hiding this comment.
For this patch, no version bump is necessary.
I will remove that with a review changes commit
| # Unfortunately, the content of the email can't be tested with Behat yet as we do not have a way to test sent emails yet. | ||
|
|
||
| @javascript | ||
| Scenario: Support form success notification is shown before content-upper blocks on the homepage |
There was a problem hiding this comment.
The test is perfecly fine and it's great that you re-used Boost Union's accessibility support form (instead of Moodle core's support form) to trigger the notification on site home.
I would just move the scenario to theme_boost_union_feelsettings_blocks.feature as its goal is to test the behaviour of blocks and not the support form.
I will move that with a review changes commit.
| {{> core/moremenu}} | ||
| </div> | ||
| {{/secondarymoremenu}} | ||
| {{{ output.course_content_header }}} |
There was a problem hiding this comment.
I am afraid that we can't move that function call that easily. The course_content_header() outputs the page notifications, but it also outputs course content which should not be moved on the page.
My gut feeling is that we could move forward by overwriting the course_content_header() function in Boost Union's core renderer class and by splitting it into two parts, the first one which just shows the notifications and the second one which just shows the course content. Both functions could then be called here in Mustache individually.
We have done something like that before with the standard_end_of_body_html_endtoken() and standard_end_of_body_html_additionalhtmlfooter() function.
Do you think you could proceed into this direction?
2 participants
…t tiles on frontpage, resolves #488
On behalf of the Boost Union Team: 🎉 Thank you for contributing! 🎉
Please note: There must be a GitHub issue for every pull request (PR)
We kindly ask you to create a github issue now if you haven't already done so.
Please make sure to follow these steps to ease the review process for the peer review team:
[ ] link your issue in the PR title, using the keyword 'resolves #ISSUE-NUMBER', e.g. 'Feature: Provide the ultimate user experience, resolves #42'
[ ] provide any further information that is relevant for peer review and not yet mentioned in the linked issue as a comment in the PR
[ ] make sure that the 'Allow edits by maintainers' checkbox is checked when creating the PR. Otherwise, the peer reviewer would not be able to push any review changes to the PR and the communication overhead increases
[ ] submit your PR in draft status to run the automated checks and review the results
[ ] in case any checks fail solve the mentioned errors by pushing the corrected code to your PR-branch
[ ] if all checks pass (or if you are unable to resolve the failing steps without any help of the review team), mark the PR as 'ready for review'
Thank you again for your contribution, we will start reviewing your PR as soon as we are able to.
In the meantime, please check our wiki page for creating pull requests and our wiki page for reviewing pull requests for further infomation about our contribution and review process.