Key-Value-Pairs Delta encoding editorial tweaks. #1366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalhosna
requested review from
ianswett,
suhasHere and
vasilvv
as code owners
Collaborator
|
We bumped it to 2^64-1 now so we wouldn't forget when we made VARINT_MAX bigger in #1016 |
michalhosna
force-pushed
the
mh/kvpair-delta-encoding-editorial
branch
from
7b87fd8 to
e611172
Compare
Contributor
Author
Ok, that makes sense. Sorry. I didn't know that merging that is close. |
afrind
added
the
Editorial
afrind
approved these changes
Nov 8, 2025
afrind
added
the
Merge Ready
ianswett
approved these changes
Nov 8, 2025
Collaborator
ianswett
left a comment
ianswett
left a comment
There was a problem hiding this comment.
Thanks, this looks good. I didn't realize quite how much text ended up in the Parameters section.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1315 Follow up.
Resubmitting my late-review proposal. I suspect my comment was ignored because getting a wire-format change into main without late unnecessary editorial discussion is good. That's why I am resubmitting. Editors, if I got that wrong, and you like the current wording, feel free to close this.
I am not sure where the last-minute change of 2^62-1 to 2^64-1 came from. I think allowing bigger value than is encodable in a single delta is wrong. It doesn't really add any value and makes the handling complex, how is one supposed to encode it if needed without prior pairs? If I understand that wrongly and there is need for 2^64-1 I think there should be an explanation somewhere.I do think the size limit should be enforced for all Key-Value-Pairs.