Clarify datagrams and subgroups #1382
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinduke
requested review from
ianswett,
suhasHere and
vasilvv
as code owners
ianswett
reviewed
Nov 30, 2025
ianswett
reviewed
Nov 30, 2025
Comment on lines
+412
to
+413
| Every object within a Group belongs to exactly one Subgroup (but zero if its | ||
| forwarding preference is Datagram). |
Collaborator
There was a problem hiding this comment.
Suggested change
| Every object within a Group belongs to exactly one Subgroup (but zero if its | |
| forwarding preference is Datagram). | |
| Every Object within a Group belongs to exactly one Subgroup or Datagram. |
ianswett
reviewed
Nov 30, 2025
Comment on lines
+3081
to
+3083
| MAY mix different forwarding preference within a single track. As a Subgroup | ||
| is by definition a set of objects delivered with Subgroup forwarding preference, | ||
| objects with a Subgroup ID have the same forwarding preference. |
Collaborator
There was a problem hiding this comment.
I don't think the second sentence is necessary, but I tried to make it clearer in case you want to keep it.
Suggested change
| MAY mix different forwarding preference within a single track. As a Subgroup | |
| is by definition a set of objects delivered with Subgroup forwarding preference, | |
| objects with a Subgroup ID have the same forwarding preference. | |
| MAY use both Subgroups and Datagrams within a Group or Track. A Subgroup | |
| is a set of Objects with the Subgroup forwarding preference, so Objects | |
| within a Subgroup ID have the same forwarding preference. |
Contributor
There was a problem hiding this comment.
"within a Subgroup ID" should be "within the same Subgroup ID" or "within a Subgroup"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1381