Replace latest Group/Object with StartGroup and StartObject #726
Conversation
Also clarify what Object is expected to be delivered first, fixing #592
ianswett
added
the
Subscribe
ianswett
requested review from
kixelated,
suhasHere and
vasilvv
as code owners
| the current object of the current group. If no content has been delivered yet, | ||
| the subscription starts with the first published or received group. | ||
| Latest Object (0x2): Specifies an open-ended subscription, beginning | ||
| with the next published Object. If no content has been delivered |
There was a problem hiding this comment.
The next published object may not be larger than Start Group/Start Object. eg: with reordering the relay has seen 2-2 when my subscribe arrives, it will say '2-3', but the next object the relay sees may be 2-1.
My current relay implementation will not deliver 2-1, so I think I agree with what's below, but maybe just this wording needs something else.
Also, given the name in the response "Start Group/Object", we might want to clearly explain there is no guarantee that such object will ever be delivered or even exists. It's just the equivalent to the field with the same name in AbsoluteStart/Range.
There was a problem hiding this comment.
I wonder if we should instead call it as "LastSeenGroup" and "LastSeenObject" .. this is the statement of truth when the subscription happened. End Subscribers now know the last known point and adjust accordingly.
| [StartGroup (i), | ||
| StartObject (i)], |
There was a problem hiding this comment.
These are in brackets - when does the receiver know they are there? Or should we always include them? For AbsoluteStart/AbsoluteRange, we just echo back what was in the request?
|
I believe @martinduke was going to take a crack at this issue as well. I'm not sure I'm completely happy with this text, so I'm going to mark it parked for now. |
Also clarify what Object is expected to be delivered first, fixing #592