Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .pre-commit-config.yaml #2804

Closed
wants to merge 5 commits into from
Closed

Conversation

mosfet80
Copy link
Contributor

@mosfet80 mosfet80 commented Apr 23, 2024

updated cmake-format-precommit to last version

Description

Please explain the changes you made, including a reference to the related issue if applicable

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

updated cmake-format-precommit to last version
@sjahr sjahr added backport-humble Mergify label that triggers a PR backport to Humble backport-iron Mergify label that triggers a PR backport to Iron labels Apr 24, 2024
@sjahr
Copy link
Contributor

sjahr commented Apr 24, 2024

@mosfet80 Can you apply the new suggestions from pre-commit to make Formatting (pre-commit) passing?

@sjahr sjahr self-requested a review April 30, 2024 12:52
@sjahr
Copy link
Contributor

sjahr commented Apr 30, 2024

Pre-commit is still failing please add the requested changes: https://github.com/moveit/moveit2/actions/runs/8812266462/job/24187624763

fix Bad indentation:
Bad indentation:
@mosfet80
Copy link
Contributor Author

Mo

@mosfet80 mosfet80 closed this May 10, 2024
@mosfet80
Copy link
Contributor Author

Patch already included into (https://github.com/moveit/moveit2/pull/2805/files#issue-comment-box)
Update .pre-commit-config.yaml #2805

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble Mergify label that triggers a PR backport to Humble backport-iron Mergify label that triggers a PR backport to Iron
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants