Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FXIOS-9203 enhanced tracking protection panel telemetry #24252

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

petruSt24
Copy link
Collaborator

📜 Tickets

Jira ticket
Github issue

💡 Description

Added the basic telemetry events for the actions happening inside the enhanced tracking protection panel

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

@petruSt24 petruSt24 requested a review from a team as a code owner January 20, 2025 20:15
bugs:
- https://github.com/mozilla-mobile/firefox-ios/issues/20371
data_reviews:
- https://github.com/mozilla-mobile/firefox-ios/pull/14102
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Data review should point this PR

@razvanlitianu
Copy link
Collaborator

@petruSt24 There are some Swiftlint warnings on this PR

@razvanlitianu
Copy link
Collaborator

@petruSt24 You also need to add Request for data collection review form and request data review.

@mobiletest-ci-bot
Copy link

Messages
📖 Project coverage: 34.18%
📖 Edited 4 files
📖 Created 1 files

Client.app: Coverage: 32.39

File Coverage
TrackingProtectionDetailsViewController.swift 0.0% ⚠️
TrackingProtectionTelemetry.swift 0.0% ⚠️
TrackingProtectionMiddleware.swift 28.57% ⚠️

Generated by 🚫 Danger Swift against 209df3c

@petruSt24
Copy link
Collaborator Author

Request for data collection review form

All questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.

  1. What questions will you answer with this data?

    • This data will help us understand users' interaction with the new menu 

  2. Why does Mozilla need to answer these questions? Are there benefits for users? Do we need this information to address product or business requirements? Some example responses:

  • We can determine whether suggestions are used by users.

  1. What alternative methods did you consider to answer these questions? Why were they not sufficient?
  • There are no other alternatives.

  1. Can current instrumentation answer these questions?
  • No.

  • List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories found on the Mozilla wiki.

  • Note that the data steward reviewing your request will characterize your data collection based on the highest (and most sensitive) category.

    Measurement Description | Data Collection Category | Tracking Bug #

    Measurement Description Data Collection Category Tracking Bug #
    tracking_protection.show_clear_cookies_alert User viewed the clear cookies alert. Category 2 - interaction 9203
    tracking_protection.tapped_clear_cookies User clicked the "Clear" button on the clear cookies alert in the ETP panel. Category 2 - interaction 9203
    tracking_protection.show_etp_details User clicked the connection status details cell on the ETP panel. Category 2 - interaction 9203
    tracking_protection.show_etp_blocked_trackers_details User clicked the blocked trackers cell on the ETP panel. Category 2 - interaction 9203
    tracking_protection.show_etp_settings User clicked the settings link on the ETP panel. Category 2 - interaction 9203
    tracking_protection.dismiss_etp_panel User dismissed the ETP panel from the close button. Category 2 - interaction 9203
    tracking_protection.show_certificates User tapped on the Show Certificates button in the ETP details screen. Category 2 - interaction 9203
    1. Please provide a link to the documentation for this data collection which describes the ultimate data set in a public, complete, and accurate way.
    1. How long will this data be collected? Choose one of the following:
    • iOS team wants to monitor this data.

    1. What populations will you measure?
      the ETP panel will have a phased released to all the users
    1. If this data collection is default on, what is the opt-out mechanism for users?

      • Default Glean SKD opt-out mechanism
    2. Please provide a general description of how you will analyze this data.

      • We will be using glean
    3. Where do you intend to share the results of your analysis?

      • Glean, iOS Team and relevant teams that interact with mozilla partners
    4. Is there a third-party tool (i.e. not Glean or Telemetry) that you are proposing to use for this data collection?

      • No third-party tools
  • @petruSt24 petruSt24 requested a review from travis79 January 21, 2025 14:20
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants