-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FXIOS-9203 enhanced tracking protection panel telemetry #24252
Merged
razvanlitianu
merged 2 commits into
main
from
Add-FXIOS-9203-trackingProtectionTelemetry
Jan 27, 2025
+125
−0
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34 changes: 34 additions & 0 deletions
34
firefox-ios/Client/Frontend/TrackingProtection/TrackingProtectionTelemetry.swift
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
// This Source Code Form is subject to the terms of the Mozilla Public | ||
// License, v. 2.0. If a copy of the MPL was not distributed with this | ||
// file, You can obtain one at http://mozilla.org/MPL/2.0/ | ||
import Glean | ||
|
||
struct TrackingProtectionTelemetry { | ||
func showClearCookiesAlert() { | ||
GleanMetrics.TrackingProtection.showClearCookiesAlert.record() | ||
} | ||
|
||
func clearCookiesAndSiteData() { | ||
GleanMetrics.TrackingProtection.tappedClearCookies.record() | ||
} | ||
|
||
func showTrackingProtectionDetails() { | ||
GleanMetrics.TrackingProtection.showEtpDetails.record() | ||
} | ||
|
||
func showBlockedTrackersDetails() { | ||
GleanMetrics.TrackingProtection.showEtpBlockedTrackersDetails.record() | ||
} | ||
|
||
func tappedShowSettings() { | ||
GleanMetrics.TrackingProtection.showEtpSettings.record() | ||
} | ||
|
||
func dismissTrackingProtection() { | ||
GleanMetrics.TrackingProtection.dismissEtpPanel.record() | ||
} | ||
|
||
func trackShowCertificates() { | ||
GleanMetrics.TrackingProtection.showCertificates.record() | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4353,6 +4353,83 @@ tracking_protection: | |
notification_emails: | ||
- [email protected] | ||
expires: "2025-07-01" | ||
show_clear_cookies_alert: | ||
type: event | ||
description: | | ||
Records when the clear cookies alert is shown | ||
bugs: | ||
- https://github.com/mozilla-mobile/firefox-ios/issues/20371 | ||
data_reviews: | ||
- https://github.com/mozilla-mobile/firefox-ios/pull/14102 | ||
notification_emails: | ||
- [email protected] | ||
expires: "2025-07-01" | ||
show_etp_details: | ||
type: event | ||
description: | | ||
Records when the enhanced tracking protection details screen is shown | ||
bugs: | ||
- https://github.com/mozilla-mobile/firefox-ios/issues/20371 | ||
data_reviews: | ||
- https://github.com/mozilla-mobile/firefox-ios/pull/14102 | ||
notification_emails: | ||
- [email protected] | ||
expires: "2025-07-01" | ||
show_etp_blocked_trackers_details: | ||
type: event | ||
description: | | ||
Records when the enhanced tracking protection blocked trackers details screen is shown | ||
bugs: | ||
- https://github.com/mozilla-mobile/firefox-ios/issues/20371 | ||
data_reviews: | ||
- https://github.com/mozilla-mobile/firefox-ios/pull/14102 | ||
notification_emails: | ||
- [email protected] | ||
expires: "2025-07-01" | ||
show_etp_settings: | ||
type: event | ||
description: | | ||
Records when the enhanced tracking protection settings screen is shown | ||
bugs: | ||
- https://github.com/mozilla-mobile/firefox-ios/issues/20371 | ||
data_reviews: | ||
- https://github.com/mozilla-mobile/firefox-ios/pull/14102 | ||
notification_emails: | ||
- [email protected] | ||
expires: "2025-07-01" | ||
tapped_clear_cookies: | ||
type: event | ||
description: | | ||
Records when the clear cookies button from the etp alert is tapped. | ||
bugs: | ||
- https://github.com/mozilla-mobile/firefox-ios/issues/20371 | ||
data_reviews: | ||
- https://github.com/mozilla-mobile/firefox-ios/pull/14102 | ||
notification_emails: | ||
- [email protected] | ||
expires: "2025-07-01" | ||
dismiss_etp_panel: | ||
type: event | ||
description: | | ||
Records when the enhanced tracking protection panel is dismissed | ||
bugs: | ||
- https://github.com/mozilla-mobile/firefox-ios/issues/20371 | ||
data_reviews: | ||
- https://github.com/mozilla-mobile/firefox-ios/pull/14102 | ||
notification_emails: | ||
- [email protected] | ||
expires: "2025-07-01" | ||
show_certificates: | ||
type: event | ||
description: | | ||
Records when the certificates screen from the enhanced tracking protection panel is shown | ||
bugs: | ||
- https://github.com/mozilla-mobile/firefox-ios/issues/20371 | ||
data_reviews: | ||
- https://github.com/mozilla-mobile/firefox-ios/pull/14102 | ||
notification_emails: | ||
- [email protected] | ||
expires: "2025-07-01" | ||
# iOS 14 widget metrics | ||
# m: medium, s: small, l: large | ||
widget: | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Data review should point this PR