Skip to content

Remove FXIOS-1235 7#26922 ⁃ Resolve testHistory - testInsertPerformance() #27226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 11, 2025

Conversation

yoanarios
Copy link
Contributor

πŸ“œ Tickets

Jira ticket
Github issue

πŸ’‘ Description

  • Remove unused ProfileTest class and only usage TestBookmarks but test has been disabled since 2020
  • Remvoe testInsertPerformance has been flaky for a while and we have several attempts to fix but test is not predictable

πŸ“ Checklist

  • I filled in the ticket numbers and a description of my work
  • I updated the PR name to follow our PR naming guidelines
  • I ensured unit tests pass and wrote tests for new code
  • If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
  • If adding telemetry, I read the data stewardship requirements and will request a data review
  • If needed, I updated documentation and added comments to complex code
  • If needed, I added a backport comment (example @Mergifyio backport release/v120)

@yoanarios yoanarios requested a review from cyndichin June 10, 2025 18:12
@yoanarios yoanarios requested a review from a team as a code owner June 10, 2025 18:13
@mobiletest-ci-bot
Copy link

Messages
πŸ“– Edited 2 files
πŸ“– Created 0 files

Generated by 🚫 Danger Swift against 141a9e1

Copy link
Contributor

@cyndichin cyndichin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the clean up! should we add a future ticket to investigate adding more metrics / performance in general and possible revisit these history cases that we are removing?

@yoanarios
Copy link
Contributor Author

yoanarios commented Jun 11, 2025

thanks for the clean up! should we add a future ticket to investigate adding more metrics / performance in general and possible revisit these history cases that we are removing?

I was planning to review history test as part of this ticket. I can also add a ticket to the test epic to track it

@yoanarios yoanarios merged commit e8cbcbf into main Jun 11, 2025
8 checks passed
@yoanarios yoanarios deleted the yrd/FXIOS-12357-remove-performance-test branch June 11, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants