Skip to content

Remove FXIOS-1235 7#26922 ⁃ Resolve testHistory - testInsertPerformance() #27226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 11, 2025
Merged

Remove FXIOS-1235 7#26922 ⁃ Resolve testHistory - testInsertPerformance() #27226

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db00356
Remove profile test and only test usage because has been skip since 2020
yoanarios Jun 10, 2025
141a9e1
Remove flaky measurement test
yoanarios Jun 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions firefox-ios/Client.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,6 @@
0BA152502CE78DAD0090B869 /* UserAgentBuilderTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 0BA1524F2CE78DAD0090B869 /* UserAgentBuilderTests.swift */; };
0BA1E00E1B03FB0B007675AF /* NetError.html in Resources */ = {isa = PBXBuildFile; fileRef = 0BA1E00D1B03FB0B007675AF /* NetError.html */; };
0BA1E0301B051A07007675AF /* NetError.css in Resources */ = {isa = PBXBuildFile; fileRef = 0BA1E02F1B051A07007675AF /* NetError.css */; };
0BA8964B1A250E6500C1010C /* ProfileTest.swift in Sources */ = {isa = PBXBuildFile; fileRef = 0BA896491A250E6500C1010C /* ProfileTest.swift */; };
0BA8964C1A250E6500C1010C /* TestBookmarks.swift in Sources */ = {isa = PBXBuildFile; fileRef = 0BA8964A1A250E6500C1010C /* TestBookmarks.swift */; };
0BB5B30B1AC0AD1F0052877D /* LoginsHelper.swift in Sources */ = {isa = PBXBuildFile; fileRef = 0BB5B30A1AC0AD1F0052877D /* LoginsHelper.swift */; };
0BBAC4BC2CDD44EC0072DB61 /* easterEggGif.gif in Resources */ = {isa = PBXBuildFile; fileRef = 0BBAC4BB2CDD44EC0072DB61 /* easterEggGif.gif */; };
0BBC50952CA1F7F900CB7248 /* BookmarksRefactorFeatureFlagProvider.swift in Sources */ = {isa = PBXBuildFile; fileRef = 0BBC50942CA1F7F900CB7248 /* BookmarksRefactorFeatureFlagProvider.swift */; };
Expand Down Expand Up @@ -2505,8 +2503,6 @@
0BA1524F2CE78DAD0090B869 /* UserAgentBuilderTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = UserAgentBuilderTests.swift; sourceTree = "<group>"; };
0BA1E00D1B03FB0B007675AF /* NetError.html */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.html; path = NetError.html; sourceTree = "<group>"; };
0BA1E02F1B051A07007675AF /* NetError.css */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.css; path = NetError.css; sourceTree = "<group>"; };
0BA896491A250E6500C1010C /* ProfileTest.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = ProfileTest.swift; sourceTree = "<group>"; };
0BA8964A1A250E6500C1010C /* TestBookmarks.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = TestBookmarks.swift; sourceTree = "<group>"; };
0BB5B30A1AC0AD1F0052877D /* LoginsHelper.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; lineEnding = 0; path = LoginsHelper.swift; sourceTree = "<group>"; xcLanguageSpecificationIdentifier = xcode.lang.swift; };
0BBAC4BB2CDD44EC0072DB61 /* easterEggGif.gif */ = {isa = PBXFileReference; lastKnownFileType = image.gif; path = easterEggGif.gif; sourceTree = "<group>"; };
0BBC50942CA1F7F900CB7248 /* BookmarksRefactorFeatureFlagProvider.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = BookmarksRefactorFeatureFlagProvider.swift; sourceTree = "<group>"; };
Expand Down Expand Up @@ -15279,7 +15275,6 @@
CA24B52024ABD7D40093848C /* PasswordManagerViewModelTests.swift */,
2FDB10921A9FBEC5006CF312 /* PrefsTests.swift */,
8ABCFEA42B45CAC300C2988A /* PrivateBrowsingTelemetryTests.swift */,
0BA896491A250E6500C1010C /* ProfileTest.swift */,
8A11C8102731CFD700AC7318 /* ReaderModeStyleTests.swift */,
03CCC9171AF05E7300DBF30D /* RelativeDatesTests.swift */,
8AFA66012CA2935C0008D0F6 /* RemoteSettings */,
Expand All @@ -15305,7 +15300,6 @@
8A95FF652B1E977E00AC303D /* TelemetryContextualIdentifierTests.swift */,
8AA6ADB42742B567004EEE23 /* TelemetryWrapperTests.swift */,
0B7B053C2D647D00007FD7AC /* TemporaryDocumentTests.swift */,
0BA8964A1A250E6500C1010C /* TestBookmarks.swift */,
4A59BF410BBD9B3BE71F4C7C /* TestHistory.swift */,
8A33222027DFE64C008F809E /* TestingHelperClasses */,
E16941B22C4E498600FF5F4E /* Toolbar */,
Expand Down Expand Up @@ -18274,7 +18268,6 @@
21ED80B32AF2E43A0065D4C7 /* TabDisplayDiffableDataSourceTests.swift in Sources */,
2165B2C42860CB34004C0786 /* MockAdjustTelemetryData.swift in Sources */,
C29B64872AD69D0200F3244B /* QRCodeCoordinatorTests.swift in Sources */,
0BA8964B1A250E6500C1010C /* ProfileTest.swift in Sources */,
8CA4E80F2D22D2C7007207C1 /* GleanUsageReportingLifecycleObserverTest.swift in Sources */,
8AE80BAF2891960300BC12EA /* MockTraitCollection.swift in Sources */,
8A55E8042BFBA9BE006DBD85 /* MicrosurveyCoordinatorTests.swift in Sources */,
Expand Down Expand Up @@ -18493,7 +18486,6 @@
8AC884212D5262070033ABF5 /* CrashTrackerTests.swift in Sources */,
C8DC90D02A067C5B0008832B /* MarkupParseUtilityTests.swift in Sources */,
21EEAA1B2D3AE3B300595119 /* BookmarksTelemetryTests.swift in Sources */,
0BA8964C1A250E6500C1010C /* TestBookmarks.swift in Sources */,
8AF3B15C2AF99C77009BB262 /* ReadingListPanelTests.swift in Sources */,
8AF99B5429EF2AF100108DEC /* MockLogger.swift in Sources */,
AB9CBC082C53B7CD00102610 /* TrackingProtectionStateTests.swift in Sources */,
Expand Down
36 changes: 0 additions & 36 deletions firefox-ios/firefox-ios-tests/Tests/ClientTests/ProfileTest.swift
View file
Open in desktop

This file was deleted.

57 changes: 0 additions & 57 deletions firefox-ios/firefox-ios-tests/Tests/ClientTests/TestBookmarks.swift
View file
Open in desktop

This file was deleted.

20 changes: 0 additions & 20 deletions firefox-ios/firefox-ios-tests/Tests/ClientTests/TestHistory.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,26 +195,6 @@ class TestHistory: XCTestCase {
self.clear(places)
}

func testInsertPerformance() {
let places = profile.places
var index = 0

measure(metrics: [
XCTMemoryMetric(),
XCTCPUMetric(), // to measure cpu cycles
XCTStorageMetric(), // to measure storage consuming
]) { () in
for _ in 0...self.numCmds {
self.addSite(
places,
url: "https://someurl\(index).com/",
title: "title \(index)"
)
index += 1
}
}
}

func testGetPerformance() {
let places = profile.places
var index = 0
Expand Down