Skip to content

Add FXIOS-12439 [Tab Tray UI Experiment] Make ExperimentTabCell constraint match Figma #27229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 11, 2025
Merged

Add FXIOS-12439 [Tab Tray UI Experiment] Make ExperimentTabCell constraint match Figma #27229

merged 1 commit into from
Jun 11, 2025

Conversation

dataports
Copy link
Contributor

📜 Tickets

Jira ticket
Github issue

💡 Description

Adjust TabTitleSupplementaryView so that ExperimentTabCell constraints are the same as in Figma.

🎥 Demos

Before

before

After

after

📝 Checklist

  • I filled in the ticket numbers and a description of my work
  • I updated the PR name to follow our PR naming guidelines
  • I ensured unit tests pass and wrote tests for new code
  • If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
  • If adding telemetry, I read the data stewardship requirements and will request a data review
  • If needed, I updated documentation and added comments to complex code
  • If needed, I added a backport comment (example @Mergifyio backport release/v120)

@dataports dataports requested a review from lmarceau June 10, 2025 19:16
@dataports dataports requested a review from a team as a code owner June 10, 2025 19:16
@mobiletest-ci-bot
Copy link

Messages
📖 Project coverage: 35.88%
📖 Edited 1 files
📖 Created 0 files

Client.app: Coverage: 35.42

File Coverage
TabTitleSupplementaryView.swift 0.0% ⚠️

Generated by 🚫 Danger Swift against 95d45d0

lmarceau
lmarceau reviewed Jun 11, 2025
View reviewed changes
firefox-ios/Client/Frontend/Browser/Tabs/Views/TabTitleSupplementaryView.swift
static let viewPosition: CGFloat = 23
static let bottomAnchorText: CGFloat = 8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, much better 😆

@dataports dataports merged commit bd21982 into main Jun 11, 2025
8 checks passed
@dataports dataports deleted the sa/fxios-12439_fix-tab-experiment-cell-spacing branch June 11, 2025 15:44
@dataports
Copy link
Contributor Author

@Mergifyio backport release/v140

@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 11, 2025 •
edited
Loading

backport release/v140

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jun 11, 2025
@dataports @mergify
Add FXIOS-12439 [Tab Tray UI Experiment] Make ExperimentTabCell const…
e482249 
…raint match Figma (#27229)

(cherry picked from commit bd21982)
@mergify mergify bot mentioned this pull request Jun 11, 2025
Merged
7 tasks
dataports pushed a commit that referenced this pull request Jun 11, 2025
@mergify
Add FXIOS-12439 [Tab Tray UI Experiment] Make ExperimentTabCell const…
0f8ab5b 
…raint match Figma (backport #27229) (#27259)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmarceau lmarceau lmarceau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dataports @mobiletest-ci-bot @lmarceau