Skip to content

Bugfix FXIOS-29068 [Telemetry] Fix missing homepage.viewed telemetry when opening new tab from toolbar. #30176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −1
Open

Bugfix FXIOS-29068 [Telemetry] Fix missing homepage.viewed telemetry when opening new tab from toolbar. #30176

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion firefox-ios/Client/Frontend/Browser/BrowserViewController/Views/BrowserViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4494,12 +4494,17 @@ extension BrowserViewController: TabManagerDelegate {
/// - Parameters:
/// - isHomeTab: A Boolean value indicating whether the current tab is the home page.
/// - webView: The `WKWebView` instance to be displayed.
/// - webView: The `WKWebView` instance to be displayed.
/// - previousTab: The previously selected tab, used to dispatch action only if opening a new homepage
/// after viewing a homepage. We want to dispatch an action that triggers impression telemetry.
private func updateEmbeddedContent(isHomeTab: Bool, with webView: WKWebView, previousTab: Tab?) {
if isHomeTab {
updateInContentHomePanel(webView.url)
guard previousTab?.isFxHomeTab ?? false else { return }
// Fix for #29068: Removed guard that prevented telemetry when navigating to homepage from non-homepage tabs.
// The guard `previousTab?.isFxHomeTab ?? false` only allowed telemetry when switching between homepages,
// causing missing homepage.viewed events when opening new tabs via the "+" toolbar button from regular webpages.
// Telemetry should fire whenever a user lands on the homepage, regardless of the previous tab type.
// guard previousTab?.isFxHomeTab ?? false else { return }
store.dispatchLegacy(
GeneralBrowserAction(
windowUUID: windowUUID,
Expand Down