Skip to content

Bugfix FXIOS-13959 [Toolbars] Homepage not clickable after navigating away from settings (iOS 15 and 16 only) #30337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
+123 −83
Open

Bugfix FXIOS-13959 [Toolbars] Homepage not clickable after navigating away from settings (iOS 15 and 16 only) #30337

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9abdef9
Trigger a layout refresh to correctly position mask for translucent t…
thatswinnie Nov 3, 2025
63acc87
Merge branch 'main' into wt/FXIOS-13959-homepage-not-clickable-after-…
thatswinnie Nov 5, 2025
801f313
Move ThemedNavigationController and ModalSettingsNavigationController
thatswinnie Nov 5, 2025
9abe0b1
Add notification
thatswinnie Nov 5, 2025
9c8acf9
Adjust fix
thatswinnie Nov 5, 2025
e87a21e
Add comment
thatswinnie Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions firefox-ios/Client/Coordinators/Browser/BrowserCoordinator.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -558,6 +558,14 @@ class BrowserCoordinator: BaseCoordinator,
func didFinishSettings(from coordinator: SettingsCoordinator) {
router.dismiss(animated: true, completion: nil)
remove(child: coordinator)

// FXIOS-13959: Changing address toolbar position from settings prevents content interaction homepage/webpage
// This bug is only happening in iOS 15 + 16
// Trigger a layout refresh to correctly position mask for translucent toolbars
if #unavailable(iOS 17) {
browserViewController.view.setNeedsLayout()
browserViewController.view.layoutIfNeeded()
}
}

func openDebugTestTabs(count: Int) {
Expand Down