Skip to content

Conversation

@thatswinnie
Copy link
Collaborator

📜 Tickets

Jira ticket
Github issue

💡 Description

Trigger a layout refresh to correctly position mask for translucent toolbars

📝 Checklist

  • I filled in the ticket numbers and a description of my work
  • I updated the PR name to follow our PR naming guidelines
  • I ensured unit tests pass and wrote tests for new code
  • If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
  • If adding telemetry, I read the data stewardship requirements and will request a data review
  • If adding or modifying strings, I read the guidelines and will request a string review from l10n
  • If needed, I updated documentation and added comments to complex code

@thatswinnie thatswinnie requested a review from a team as a code owner November 3, 2025 15:05
@mobiletest-ci-bot
Copy link

mobiletest-ci-bot commented Nov 3, 2025

Messages
📖 Project coverage: 38.22%

🥇 Perfect PR size

Smaller PRs are easier to review. Thanks for making life easy for reviewers! ✨

🦊 BrowserViewController Check

We’re tracking the size of BrowserViewController.swift to keep it healthy.

  • ✨ Change in file size: +13 lines

❌ Per-file test coverage gate

The following changed file(s) are below 35.0% coverage:

File Coverage Required
firefox-ios/Client/Frontend/Components/ModalSettingsNavigationController.swift 0.0% 35.0%
firefox-ios/Client/Frontend/Browser/BrowserViewController/Views/BrowserViewController.swift 30.6% 35.0%

Client.app: Coverage: 37.02

File Coverage
BrowserViewController.swift 30.6% ⚠️
ThemedNavigationController.swift 82.22%
ModalSettingsNavigationController.swift 0.0% ⚠️
SettingsNavigationController.swift 0.0% ⚠️
BrowserCoordinator.swift 67.69%

Generated by 🚫 Danger Swift against e87a21e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants