Skip to content

Refactor FXIOS-14031 [Danger] Danger rule with dispatch legacy #30420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+8 −0
Open

Refactor FXIOS-14031 [Danger] Danger rule with dispatch legacy #30420

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e57d96e
Add Dispatch legacy check
lmarceau Nov 5, 2025
72c59b2
swiftlint
lmarceau Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions Dangerfile.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,6 +316,7 @@ class CodeUsageDetector {
case deferred
case swiftUIText
case task
case dispatchLegacy

var message: String {
switch self {
Expand All @@ -336,6 +337,11 @@ class CodeUsageDetector {
New `Task {}` added in file %@ at line %d.
Please add a concurrency reviewer on your PR: \(contacts)
"""
case .dispatchLegacy:
return """
DispatchLegacy is used in file %@ at line %d.
Please replace with `dispatch` instead and call it from the main actor
"""
}
}

Expand All @@ -353,6 +359,8 @@ class CodeUsageDetector {
return "Text(\""
case .task:
return " Task {"
case .dispatchLegacy:
return ".dispatchLegacy("
}
}

Expand Down