Skip to content

Refactor FXIOS-14031 [Danger] Danger rule with dispatch legacy#30420

Merged
lmarceau merged 2 commits intomainfrom
lm/danger-dispatchLegacy
Nov 6, 2025
Merged

Refactor FXIOS-14031 [Danger] Danger rule with dispatch legacy#30420
lmarceau merged 2 commits intomainfrom
lm/danger-dispatchLegacy

Conversation

@lmarceau
Copy link
Contributor

@lmarceau lmarceau commented Nov 5, 2025

📜 Tickets

Jira ticket
Github issue

💡 Description

Add check so we fail if new dispatchLegacy are introduced in the codebase

📝 Checklist

  • I filled in the ticket numbers and a description of my work
  • I updated the PR name to follow our PR naming guidelines
  • I ensured unit tests pass and wrote tests for new code
  • If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
  • If adding telemetry, I read the data stewardship requirements and will request a data review
  • If adding or modifying strings, I read the guidelines and will request a string review from l10n
  • If needed, I updated documentation and added comments to complex code

@lmarceau lmarceau requested a review from yoanarios November 5, 2025 21:53
@lmarceau lmarceau requested a review from a team as a code owner November 5, 2025 21:53
@mobiletest-ci-bot
Copy link

🧹 Tidy commit

Just 1 file(s) touched. Thanks for keeping it clean and review-friendly!

❌ Per-file test coverage gate

The following changed file(s) are below 35.0% coverage:

File Coverage Required
Dangerfile.swift 0.0% 35.0%

Generated by 🚫 Danger Swift against 72c59b2

@lmarceau lmarceau merged commit d8c2865 into main Nov 6, 2025
9 checks passed
@lmarceau lmarceau deleted the lm/danger-dispatchLegacy branch November 6, 2025 16:39
@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2025

🚀 PR merged to main, targeting version: 145.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants