Skip to content

Conversation

@yashikakhurana
Copy link

📜 Tickets

Jira ticket
Github issue

💡 Description

When first adding the date installed and date updated, we added a method to calculate those using the home directory.

However, both the Kotlin and the Swift sides of the SDK ended up passing null values for it and it isn't used anywhere. This PR removes the homeDirectory from the AppContext

🎥 Demos

Before After
Demo

📝 Checklist

  • I filled in the ticket numbers and a description of my work
  • I updated the PR name to follow our PR naming guidelines
  • I ensured unit tests pass and wrote tests for new code
  • If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
  • If adding telemetry, I read the data stewardship requirements and will request a data review
  • If adding or modifying strings, I read the guidelines and will request a string review from l10n
  • If needed, I updated documentation and added comments to complex code

Copy link
Collaborator

@issammani issammani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @yashikakhurana. Thanks for the PR ! I left a comment about changing Generated/ files. You will need to make the change in AS first. The changes for NimbusCreate.swift are good though when we have a new AS version removing home_directory from rust 😄

public var androidSdkVersion: String?
public var debugTag: String?
public var installationDate: Int64?
public var homeDirectory: String?
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't change files under Generated/ since they will be overwritten by the next AS bump. These are directly generated from uniffi. If you want this to be removed you need to remove it upstream here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reverted the changes regarding the generate files, thank you for sharing that. And yes AS pr is up here mozilla/application-services#7085 🙏

public var androidSdkVersion: String?
public var debugTag: String?
public var installationDate: Int64?
public var homeDirectory: String?
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above 😄

Copy link
Collaborator

@issammani issammani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Thanks. Will trigger CI once the AS bump with the change from mozilla/application-services#7085 lands here

@issammani issammani added the Do Not Merge ⛔️ This issue is a work in progress and is not ready to land label Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Do Not Merge ⛔️ This issue is a work in progress and is not ready to land

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants