-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Refactor FXIOS-30781 [Nimbus]: Remove passing the home directory to App context in ios #30782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Refactor FXIOS-30781 [Nimbus]: Remove passing the home directory to App context in ios #30782
Conversation
issammani
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @yashikakhurana. Thanks for the PR ! I left a comment about changing Generated/ files. You will need to make the change in AS first. The changes for NimbusCreate.swift are good though when we have a new AS version removing home_directory from rust 😄
| public var androidSdkVersion: String? | ||
| public var debugTag: String? | ||
| public var installationDate: Int64? | ||
| public var homeDirectory: String? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't change files under Generated/ since they will be overwritten by the next AS bump. These are directly generated from uniffi. If you want this to be removed you need to remove it upstream here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reverted the changes regarding the generate files, thank you for sharing that. And yes AS pr is up here mozilla/application-services#7085 🙏
| public var androidSdkVersion: String? | ||
| public var debugTag: String? | ||
| public var installationDate: Int64? | ||
| public var homeDirectory: String? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above 😄
…pp context in ios
f65dff6 to
75dec4f
Compare
issammani
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! Thanks. Will trigger CI once the AS bump with the change from mozilla/application-services#7085 lands here
📜 Tickets
Jira ticket
Github issue
💡 Description
When first adding the date installed and date updated, we added a method to calculate those using the home directory.
However, both the Kotlin and the Swift sides of the SDK ended up passing null values for it and it isn't used anywhere. This PR removes the
homeDirectoryfrom the AppContext🎥 Demos
Demo
📝 Checklist