Bug 2000264: [ci full] Remove passing the home directory to the Rust SDK #7085
+18
−83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freshstrangemusic
previously requested changes
Nov 18, 2025
| // Note that installation date is | ||
| // the unix time, which is milliseconds since epoch | ||
| i64? installation_date; | ||
| string? home_directory; |
Member
There was a problem hiding this comment.
This will be a breaking change against iOS. Please do the following:
- add a changelog entry
- file a PR against mozilla-mobile/firefox-ios updating the following files to remove the homeDirectory argument:
- https://github.com/mozilla-mobile/firefox-ios/blob/aa70becbf0b7623b615ab46ab9c4b8b17b93ab64/MozillaRustComponents/Sources/FocusRustComponentsWrapper/Nimbus/NimbusCreate.swift#L139
- https://github.com/mozilla-mobile/firefox-ios/blob/aa70becbf0b7623b615ab46ab9c4b8b17b93ab64/MozillaRustComponents/Sources/MozillaRustComponentsWrapper/Nimbus/NimbusCreate.swift#L147
- add
[ci full]to your PR title to trigger a full integration run with CI
once thats complete, you can check the "this is a breaking change" checkbox in the PR description
Contributor
Author
There was a problem hiding this comment.
here ios pr mozilla-mobile/firefox-ios#30782
Contributor
Author
There was a problem hiding this comment.
okay added changelog, ios PR and added ci full to trigger full integration run
Contributor
Author
There was a problem hiding this comment.
okay @freshstrangemusic got r+ here mozilla-mobile/firefox-ios#30782
yashikakhurana
changed the title
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
[ci full]to the PR title.