-
Notifications
You must be signed in to change notification settings - Fork 138
VPN-6766 - Android Qt 6.9 #10738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mcleinman
wants to merge
36
commits into
main
Choose a base branch
from
vpn-6766-android-qt-6.9
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
VPN-6766 - Android Qt 6.9 #10738
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
42476a8 to
a87bf24
Compare
a87bf24 to
d6033b4
Compare
hneiva
approved these changes
Sep 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes under taskcluster/ LGTM
5 tasks
strseb
approved these changes
Oct 29, 2025
5058a43 to
66098ce
Compare
66098ce to
5a4f6ac
Compare
…ozilla-vpn-client into vpn-6766-android-qt-6.9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While this builds on my machine™️, I haven't done the work to make TaskCluster happy. More worrisome, there is a runtime crash on launch, occuring as soon as something C++ tries to grab the Android context. I'm going to put this down for a bit and come back to it, but for posterity:
Yet to do
Thoughts
A partial list of things I've tried, but didn't fix the run time crash:
- [ ] Tried a new class like AppContextHolder (different one for both daemon and main app), and getting that initialized first, before anything else. That didn’t help.
- [ ] Tried expiclity adding Qt::Core to src/CmakeLists.txt with the other ones - didn’t help
- [ ] I checked the combined manifest file. It was being combined just fine.
- [ ] In VPNActivity.java, confirmed the onCreate activity was the same one being used in onResume via System.identityHashCode(this), and so we weren’t accidentally creating a new one each time or something
- [ ] Changed android:launchmode in Manifest file from “singleTop” to “singleTask”
- [ ] Added in PRE_LINK into the ndk_openssl_merged command in android_openssl.cmake - didn’t help
- [ ] Commenting out
QNetworkInformation::loadDefaultBackend();gets it a little bit further than otherwise, but only because it skips what the first crash would be.- [ ] Commented out
removeUnusedEntriesAfterDays = 30(from android/settings.gradle). Don’t remember why - maybe there was a warning?- [ ] Removing
RESOURCE_PREFIX /qt/qmlfrom src/ui/CMakeLists.txt, as there is a comment about removing that once we only compile with it- [ ] Android/common/build.gradle has 2 entries under
dependenciesofimplementation project(path: ':qtBindings’). Removing one of them doesn’t change anything.- [ ] Added
implementation fileTree(dir: '../libs', include: ['*.jar', '*.aar’])underdependenciesinandroid/common/build.gradle(Why? Probably something I saw online. Don’t remember.)- [ ] Including
repositories { flatDir { dirs($rootDir/libs) } }inandroid/common/build.gradleandandroid/vpnClient/build.gradle- [ ] Using a namespace of 'org.mozilla.firefox.vpn' for vpnClient
- [ ] Upping the compileSdkVersion and targetSdkVersion to 35 (and making a few other small adjustments so things compile), and seeing if that fixes everything (it doesn’t)
- [ ] I believe we shouldn’t be using QtApplicationBase/QtActivityBase - should use the derived class (in my PR)
- [ ] ClientCommon was never used and was throwing warnings, so I removed it
Description
Reference
Checklist