VPN-7324: 2.33 addon messages #10856
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flodolo
requested changes
Nov 6, 2025
|
|
||
| 233updateMessage: | ||
| bullet1: | ||
| value: "[all] Finish transitioning subscription management to the Mozilla Accounts website." |
There was a problem hiding this comment.
Suggested change
| value: "[all] Finish transitioning subscription management to the Mozilla Accounts website." | |
| value: "[all] Finish transitioning subscription management to the Mozilla accounts website." |
Did you mean "Finished"? "Finish" sounds like a plan, not a release note. Also, accounts always lowercase.
| value: "[all] Finish transitioning subscription management to the Mozilla Accounts website." | ||
| comment: Bullet point with a specific update in 2.33. Should have tag that indicates it applies to all platforms. | ||
| bullet2: | ||
| value: "[all] Added regular key rotation, improving security in the event of extreme, unexpected situations." |
There was a problem hiding this comment.
extreme, unexpected situations sounds unnecessarily ominous. What are those?
| value: "[Windows, macOS, Linux] In a rare situation, the status icon wasn’t updating. We dug in deep, and it should again work for everyone." | ||
| comment: Bullet point with a specific update in 2.33. Should have tag that indicates it applies to the 3 desktop platforms. | ||
| bullet6: | ||
| value: "[Linux] If your distro ships with that latest Qt 6.10, builds from scratch may have had issues. They no longer should." |
There was a problem hiding this comment.
This seems relevant for an extremely small number of users? Will they even see the update message if they build their own?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moving towards giving more descriptive update and what's new messages. It's possible some of these features won't make it, and we'll hold the bullet point for the following release.
Reference
VPN-7324
Checklist