Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 0 additions & 55 deletions addons/message_update_v2.32/manifest.json

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ if (('updateTime' in api.settings)) {
// Macos v2.16.0 requires a web-based update.
if (api.env.platform === 'macos' && api.env.versionString === '2.16.0') {
api.addon.setTitle(
'message.message_update_v2.32.block.extra_1',
'message.message_update_v2.33.block.extra_1',
'Download the new Mozilla VPN');
api.addon.composer.remove('c_3');
return;
Expand Down Expand Up @@ -51,6 +51,6 @@ if (versionCompare([2, 13, 0], version) >= 0 ||
api.addon.composer.remove('c_3');

api.addon.setTitle(
'message.message_update_v2.32.block.extra_1',
'message.message_update_v2.33.block.extra_1',
'Download the new Mozilla VPN');
})
105 changes: 105 additions & 0 deletions addons/message_update_v2.33/manifest.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,105 @@
{
"api_version": "0.1",
"id": "message_update_v2.33",
"name": "Update to Mozilla VPN 2.33",
"type": "message",
"conditions": {
"max_client_version": "2.32.9",
"javascript": "osCheck.js"
},
"javascript": {
"enable": "enable.js"
},
"message": {
"date": 1763575587,
"usesSharedStrings": true,
"shortVersion": "2.33",
"id": "message_update_v2.33",
"title": "vpn.commonStrings.updateTitle",
"subtitle": "vpn.commonStrings.subtitle",
"badge": "new_update",
"blocks": [
{
"id": "c_1",
"type": "text",
"content": "vpn.commonStrings.generalUpdateBulletIntro"
},
{
"id": "c_2",
"type": "ulist",
"content": [
{
"id": "l_1",
"content": "vpn.233updateMessage.bullet1"
},
{
"id": "l_2",
"content": "vpn.233updateMessage.bullet2"
},
{
"id": "l_3",
"content": "vpn.233updateMessage.bullet3"
},
{
"id": "l_4",
"content": "vpn.233updateMessage.bullet4"
},
{
"id": "l_5",
"content": "vpn.233updateMessage.bullet5"
},
{
"id": "l_6",
"content": "vpn.233updateMessage.bullet6"
},
{
"id": "l_7",
"content": "vpn.233updateMessage.bullet7"
},
{
"id": "l_8",
"content": "vpn.233updateMessage.bullet8"
},
{
"id": "l_9",
"content": "vpn.233updateMessage.bullet9"
},
{
"id": "l_10",
"content": "vpn.233updateMessage.bullet10"
},
{
"id": "l_11",
"content": "vpn.233updateMessage.bullet11"
}
]
},
{
"id": "c_3",
"type": "button",
"style": "primary",
"content": "vpn.commonStrings.updateButton",
"javascript": "update.js"
},
{
"id": "c_4",
"type": "button",
"style": "primary",
"content": "vpn.commonStrings.downloadButton",
"javascript": "updateWeb.js"
},
{
"id": "c_5",
"type": "button",
"style": "link",
"content": "vpn.commonStrings.getHelpButton",
"javascript": "getHelp.js"
},
{
"id": "extra_1",
"type": "text",
"content": "vpn.commonStrings.downloadTitle"
}
]
}
}
85 changes: 85 additions & 0 deletions addons/message_whats_new_v2.33/manifest.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,85 @@
{
"api_version": "0.1",
"id": "message_whats_new_v2.33",
"name": "What's new message",
"type": "message",
"conditions": {
"min_client_version": "2.33.0",
"max_client_version": "2.33.9"
},
"javascript": {
"enable": "setDate.js"
},
"message": {
"date": 1763575587,
"usesSharedStrings": true,
"shortVersion": "2.33",
"id": "message_whats_new_v2.33",
"title": "vpn.commonStrings.whatsNewTitle",
"subtitle": "vpn.commonStrings.latestVersionSubtitle",
"badge": "whats_new",
"notify": false,
"blocks": [
{
"id": "c_1",
"type": "text",
"content": "vpn.commonStrings.generalUpdateBulletIntro"
},
{
"id": "c_2",
"type": "ulist",
"content": [
{
"id": "l_1",
"content": "vpn.233updateMessage.bullet1"
},
{
"id": "l_2",
"content": "vpn.233updateMessage.bullet2"
},
{
"id": "l_3",
"content": "vpn.233updateMessage.bullet3"
},
{
"id": "l_4",
"content": "vpn.233updateMessage.bullet4"
},
{
"id": "l_5",
"content": "vpn.233updateMessage.bullet5"
},
{
"id": "l_6",
"content": "vpn.233updateMessage.bullet6"
},
{
"id": "l_7",
"content": "vpn.233updateMessage.bullet7"
},
{
"id": "l_8",
"content": "vpn.233updateMessage.bullet8"
},
{
"id": "l_9",
"content": "vpn.233updateMessage.bullet9"
},
{
"id": "l_10",
"content": "vpn.233updateMessage.bullet10"
},
{
"id": "l_11",
"content": "vpn.233updateMessage.bullet11"
}
]
},
{
"id": "c_3",
"type": "text",
"content": "vpn.commonStrings.whatsNewClosing"
}
]
}
}
3 changes: 3 additions & 0 deletions addons/message_whats_new_v2.33/setDate.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
(function(api) {
api.addon.date = (api.settings.updateTime.getTime() / 1000);
})
35 changes: 35 additions & 0 deletions addons/strings.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,41 @@ commonStrings:
value: An option, under “Preferences”, to enable support for RCS/MMS messaging, Apple features like CarPlay and AirDrop, as well as connections to local devices.
comment: First bullet point with a specific update in 2.31 - shown only on iOS

233updateMessage:
bullet1:
value: "[all] Finish transitioning subscription management to the Mozilla Accounts website."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
value: "[all] Finish transitioning subscription management to the Mozilla Accounts website."
value: "[all] Finish transitioning subscription management to the Mozilla accounts website."

Did you mean "Finished"? "Finish" sounds like a plan, not a release note. Also, accounts always lowercase.

comment: Bullet point with a specific update in 2.33. Should have tag that indicates it applies to all platforms.
bullet2:
value: "[all] Added regular key rotation, improving security in the event of extreme, unexpected situations."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extreme, unexpected situations sounds unnecessarily ominous. What are those?

comment: Bullet point with a specific update in 2.33. Should have tag that indicates it applies to all platforms.
bullet3:
value: "[iOS] If you are using that beautiful new iPhone Air, Mozilla VPN should now look even better on it."
comment: Bullet point with a specific update in 2.33. Should have tag that indicates it applies to iOS platform.
bullet4:
value: "[iOS] Improvements on when notification permissions are requested when the app launches for the first time."
comment: Bullet point with a specific update in 2.33. Should have tag that indicates it applies to iOS platform.
bullet5:
value: "[Windows, macOS, Linux] In a rare situation, the status icon wasn’t updating. We dug in deep, and it should again work for everyone."
comment: Bullet point with a specific update in 2.33. Should have tag that indicates it applies to the 3 desktop platforms.
bullet6:
value: "[Linux] If your distro ships with that latest Qt 6.10, builds from scratch may have had issues. They no longer should."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems relevant for an extremely small number of users? Will they even see the update message if they build their own?

comment: Bullet point with a specific update in 2.33. Should have tag that indicates it applies to Linux platform.
bullet7:
value: "[iOS] Some exciting under-the-hood work to support a future feature."
comment: Bullet point with a specific update in 2.33. Should have tag that indicates it applies to iOS platform.
bullet8:
value: "[Android] Invisible work that will allow the app to run smoother on the latest devices."
comment: Bullet point with a specific update in 2.33. Should have tag that indicates it applies to Android platform.
bullet9:
value: "[macOS] Over the past few releases we’ve improved how the VPN operates under the hood. This release completes that work."
comment: Bullet point with a specific update in 2.33. Should have tag that indicates it applies to macOS platform.
bullet10:
value: "[Linux] Some behind-the-scenes changes that help us get new versions out to you more easily."
comment: Bullet point with a specific update in 2.33. Should have tag that indicates it applies to Linux platform.
bullet11:
value: "[all] You can use Mozilla VPN in dozens of languages, and we’ve included the latest translations in this release."
comment: Bullet point with a specific update in 2.33. Should have tag that indicates it applies to all platforms.

tryFirefoxExtension:
title:
value: Try the Firefox extension
Expand Down
2 changes: 2 additions & 0 deletions docs/Components/Addons/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,8 @@ If you want to implement new add-ons, you need to follow these steps:
3. If new shared strings were added, process them so that strings are shown in the addon:
Delete the `build-addons` directory (if one exists) and run
`python ./scripts/utils/generate_shared_addon_xliff.py -i ./addons/strings.yaml -o ./3rdparty/i18n/en/addons/strings.xliff`
To run this script, the Qt bin directory (something like `~/Qt/6.9.3/macos/bin`) must be
in your PATH variable.
(This step is not necessary, strictly speaking. This script is what will be run as new
strings are ingested into l10n repo, and once the new strings have done a round trip to
the l10n repo and then back to the client repo, the string will show up in the addon as
Expand Down
Loading