Skip to content

Bug 1995662 - guard create_login_store_with_nss_keymanager#7100

Merged
jo merged 1 commit intomozilla:mainfrom
jo:harden_create_login_store_with_nss_keymanager
Nov 25, 2025
Merged

Bug 1995662 - guard create_login_store_with_nss_keymanager#7100
jo merged 1 commit intomozilla:mainfrom
jo:harden_create_login_store_with_nss_keymanager

Conversation

@jo
Copy link
Contributor

@jo jo commented Nov 24, 2025

Note that the only consumer of this method (Desktop Login Manager) already catches the method call, therefore this change will not break.

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

@jo jo requested a review from bendk November 24, 2025 09:09
@jo jo force-pushed the harden_create_login_store_with_nss_keymanager branch from 6b42106 to 6cc3262 Compare November 24, 2025 09:40
Copy link
Contributor

@bendk bendk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems good to me, thanks.

@jo jo added this pull request to the merge queue Nov 25, 2025
Merged via the queue into mozilla:main with commit 8cd5b5e Nov 25, 2025
13 checks passed
@jo jo deleted the harden_create_login_store_with_nss_keymanager branch November 25, 2025 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants