Bug 1995662 - guard create_login_store_with_nss_keymanager#7100
Merged
jo merged 1 commit intomozilla:mainfrom Nov 25, 2025
Merged
Bug 1995662 - guard create_login_store_with_nss_keymanager#7100jo merged 1 commit intomozilla:mainfrom
jo merged 1 commit intomozilla:mainfrom
Conversation
6b42106 to
6cc3262
Compare
bendk
approved these changes
Nov 24, 2025
Contributor
bendk
left a comment
There was a problem hiding this comment.
This seems good to me, thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that the only consumer of this method (Desktop Login Manager) already catches the method call, therefore this change will not break.
Pull Request checklist
[ci full]to the PR title.