-
Notifications
You must be signed in to change notification settings - Fork 947
WT-303: New Mozilla ads pages #16810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lucianoratamero
wants to merge
51
commits into
main
Choose a base branch
from
wt-303-ads-solutions-page
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dark-section css files
…ol, and m24 sizing.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16810 +/- ##
==========================================
- Coverage 79.70% 79.66% -0.05%
==========================================
Files 159 159
Lines 8534 8545 +11
==========================================
+ Hits 6802 6807 +5
- Misses 1732 1738 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the new pages for the Mozilla Ads section.
It contains:
Significant changes and points to review
Issue / Bugzilla link
https://mozilla-hub.atlassian.net/browse/WT-302
https://mozilla-hub.atlassian.net/browse/WT-303
https://mozilla-hub.atlassian.net/browse/WT-304
https://mozilla-hub.atlassian.net/browse/WT-305
Testing
I have the designs fully implemented on the remainder of the Ads pages. Some notes:
Please review for design as well, as all of the typography has been refactored to better align with the base styles, and there are a lot of new patterns here too.
https://www-demo1.allizom.org/en-US/advertising/
https://www-demo1.allizom.org/en-US/advertising/solutions/
https://www-demo1.allizom.org/en-US/advertising/why-mozilla/
https://www-demo1.allizom.org/en-US/advertising/principles/