-
Notifications
You must be signed in to change notification settings - Fork 947
WT-334 - Build CMS Components For Advertising Pages - Part 1 #16813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: wt-303-ads-solutions-page
Are you sure you want to change the base?
WT-334 - Build CMS Components For Advertising Pages - Part 1 #16813
Conversation
…o mozorg/advertising/landing.html
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## wt-303-ads-solutions-page #16813 +/- ##
=============================================================
+ Coverage 79.66% 79.88% +0.22%
=============================================================
Files 159 160 +1
Lines 8545 8640 +95
=============================================================
+ Hits 6807 6902 +95
Misses 1738 1738 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Conflict likely related to quick stop-gap we merged this morning to fix an issue with button contrast in prod: #16829 (it might not like that there was an update to a file deleted here) |
… has not alt text
simplify user editing experience by limiting the number of editable fields; since the images will likely be used only 1 time, the alt text can be defined at the image level
…zilla/bedrock into WT-334-cms-components-for-advertising
If this changeset needs to go into the FXC codebase, please add the
WMO and FXClabel.This pull request includes the work from on #16810, which should be reviewed first
One-line summary
This pull request makes the advertising index/landing page editable through Wagtail.
Significant changes and points to review
This pull request turns the advertising page into a Wagtail-managed
AdvertisingIndexPagepage with the following components, defined inbedrock/mozorg/blocks/advertising.py:advertising_hero_blocksection_header_blockfigure_with_statistic_blockfeature_list_blockAlso, a new snippet (
ContactBannerSnippet) is available, and added to theAdvertisingIndexPage.Issue / Bugzilla link
WT-334
Testing
To test locally, go to Wagtail and create an "Advertising index page" page in the page tree. Try to make the content identical to http://localhost:8000/en-US/advertising/.