Skip to content

Conversation

@dchukhin
Copy link
Collaborator

@dchukhin dchukhin commented Oct 17, 2025

If this changeset needs to go into the FXC codebase, please add the WMO and FXC label.

This pull request depends on #16813, which should be reviewed first

One-line summary

This pull request makes the advertising principles subpage editable through Wagtail.

Significant changes and points to review

Following the work in #16813, this pull request adds an TwoColumnSubpage with the fields necessary to make it editable through Wagtail.

Issue / Bugzilla link

WT-334

Testing

To test locally, go to Wagtail and create an "Advertising principles page" page in the page tree (as a child of an "Advertising index page"). Try to make the content identical to http://localhost:8000/en-US/advertising/principles/.

@codecov
Copy link

codecov bot commented Oct 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.95%. Comparing base (47077ae) to head (98fb0f7).

Additional details and impacted files
@@                            Coverage Diff                            @@
##           WT-334-cms-components-for-advertising   #16814      +/-   ##
=========================================================================
+ Coverage                                  79.88%   79.95%   +0.07%     
=========================================================================
  Files                                        160      160              
  Lines                                       8640     8671      +31     
=========================================================================
+ Hits                                        6902     6933      +31     
  Misses                                      1738     1738              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@stephaniehobson stephaniehobson added Needs Review Awaiting code review Frontend HTML, CSS, JS... client side stuff Wagtail Development related to our use of Wagtail CMS labels Oct 20, 2025
Copy link
Collaborator

@kkellydesign kkellydesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make this one a little more generic. Call this page type a "Two-column subpage." The child pages for the Advertising section will be this one, and another that is more component-based like the index page. I've merged our other work on this here: http://localhost:8000/en-US/advertising/solutions/ (For now, this is unneccessary context, as these additional two subpages aren't yet approved.)

I'll also add that I just merged in Luciano's work, and then reverted that commit because I realized it's still in flux. So in an effort to keep your branch clean, it's now only updated with main.

This page will eventually be used for the contact page as well (Luciano's branch is live on the demo server right now awaiting review.), so we'll need the right column to accept a form, and/or an embed. Again, this isn't fully specced yet, so no need to build anything for this yet.

So for this PR:

  • Change the PageType name to "Two-column subpage"
  • Make the right column a streamfield that accepts a normal richtext field, and also your current model fields as a "Detail List" component.

@dchukhin dchukhin changed the base branch from main to WT-334-cms-components-for-advertising November 5, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Frontend HTML, CSS, JS... client side stuff Needs Review Awaiting code review Wagtail Development related to our use of Wagtail CMS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants