-
Notifications
You must be signed in to change notification settings - Fork 947
WT-334 - Build CMS Components For Advertising Pages - Part 2 #16814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: WT-334-cms-components-for-advertising
Are you sure you want to change the base?
WT-334 - Build CMS Components For Advertising Pages - Part 2 #16814
Conversation
…y be a child of AdvertisingIndexPage
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## WT-334-cms-components-for-advertising #16814 +/- ##
=========================================================================
+ Coverage 79.88% 79.95% +0.07%
=========================================================================
Files 160 160
Lines 8640 8671 +31
=========================================================================
+ Hits 6902 6933 +31
Misses 1738 1738 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…or-advertising-subpage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make this one a little more generic. Call this page type a "Two-column subpage." The child pages for the Advertising section will be this one, and another that is more component-based like the index page. I've merged our other work on this here: http://localhost:8000/en-US/advertising/solutions/ (For now, this is unneccessary context, as these additional two subpages aren't yet approved.)
I'll also add that I just merged in Luciano's work, and then reverted that commit because I realized it's still in flux. So in an effort to keep your branch clean, it's now only updated with main.
This page will eventually be used for the contact page as well (Luciano's branch is live on the demo server right now awaiting review.), so we'll need the right column to accept a form, and/or an embed. Again, this isn't fully specced yet, so no need to build anything for this yet.
So for this PR:
- Change the PageType name to "Two-column subpage"
- Make the right column a streamfield that accepts a normal richtext field, and also your current model fields as a "Detail List" component.
…components-for-advertising-subpage
…b.com:mozilla/bedrock into WT-334-cms-components-for-advertising-subpage
…components-for-advertising-subpage
…components-for-advertising-subpage
…components-for-advertising-subpage
…components-for-advertising-subpage
…components-for-advertising-subpage
…components-for-advertising-subpage
…components-for-advertising-subpage
…components-for-advertising-subpage
If this changeset needs to go into the FXC codebase, please add the
WMO and FXClabel.This pull request depends on #16813, which should be reviewed first
One-line summary
This pull request makes the advertising principles subpage editable through Wagtail.
Significant changes and points to review
Following the work in #16813, this pull request adds an
TwoColumnSubpagewith the fields necessary to make it editable through Wagtail.Issue / Bugzilla link
WT-334
Testing
To test locally, go to Wagtail and create an "Advertising principles page" page in the page tree (as a child of an "Advertising index page"). Try to make the content identical to http://localhost:8000/en-US/advertising/principles/.