WT-334 - Build CMS Components For Advertising Pages - Part 3 #16815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dark-section css files
…ol, and m24 sizing.
…o mozorg/advertising/landing.html
…334-cms-components-for-advertising-sub-navigation
…334-cms-components-for-advertising-sub-navigation
…334-cms-components-for-advertising-sub-navigation
…zilla/bedrock into WT-334-cms-components-for-advertising
…components-for-advertising-subpage
…334-cms-components-for-advertising-sub-navigation
…334-cms-components-for-advertising-sub-navigation
…components-for-advertising-subpage
…334-cms-components-for-advertising-sub-navigation
…f github.com:mozilla/bedrock into WT-334-cms-components-for-advertising-sub-navigation
…334-cms-components-for-advertising-sub-navigation
…components-for-advertising-subpage
…334-cms-components-for-advertising-sub-navigation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this changeset needs to go into the FXC codebase, please add the
WMO and FXClabel.This pull request depends on #16814, which should be reviewed first
One-line summary
This pull request makes the advertising sub-navigation editable through Wagtail.
Significant changes and points to review
Following the work in #16814, this pull request adds
NavigationLinkBlockwith the fields necessary for navigation links (types of links are: 1. a block on the Advertising index page, 2. an internal page, 3. an external link)sub_navigationstreamfield toAdvertisingIndexPage, so users can create multiple items in the sub-navigationAdvertisingIndexPage, verifying that subnavigation items are valid (can't choose a non-existent block, can't remove a block that's being used as a link, etc.)Issue / Bugzilla link
WT-334
Testing
To test locally, go to Wagtail and create/edit an "Advertising index page" page in the page tree, and create a sub-navigation in the "Settings" panel. Try to make the sub-navigation identical to what is on http://localhost:8000/en-US/advertising/. Also, verify that the same sub-navigation exists on all children of the Advertising index page.